Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old August 1, 2019, 20:54   #321
Pondlife
Apprentice
 
Join Date: Mar 2010
Location: UK
Posts: 76
Pondlife is on a distinguished road
Playing a gnome mage on latest nightly build (gbaacb2d0c) on Windows 10 x64.

When my character dies and I select "n) new game" at the tombstone screen, sometimes the application dies immediately after displaying "Initialization complete" (or something similar - it only appears for a moment). The window just disappears. Re-starting the application works fine.

This is not always reproducable though - sometimes it happens, and sometimes it doesn't.
__________________
Playing roguelikes on and off since 1984.
rogue, hack, moria, nethack, angband & zangband.
Pondlife is offline   Reply With Quote
Old August 1, 2019, 21:50   #322
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,786
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by Pondlife View Post
Playing a gnome mage on latest nightly build (gbaacb2d0c) on Windows 10 x64.

When my character dies and I select "n) new game" at the tombstone screen, sometimes the application dies immediately after displaying "Initialization complete" (or something similar - it only appears for a moment). The window just disappears. Re-starting the application works fine.

This is not always reproducable though - sometimes it happens, and sometimes it doesn't.
Thanks - I'm a bit surprised there haven't been more problems with this.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 3, 2019, 01:17   #323
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,786
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
It is indeed much nicer. I've updated my iterator to reflect on this, keeping pointers instead of structures because I don't like passing structs to functions.
On reflection, I think the best way to handle this whole idea is to create a point_set of the relevant grids (probably by making a new create_rectangle_point_set(), or something), and then iterate across the point_set.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 3, 2019, 02:54   #324
clouded
Adept
 
Join Date: Jun 2012
Posts: 225
clouded is on a distinguished road
Quote:
Originally Posted by Pete Mack View Post
Yeah, that is sometimes a problem, too. But it was the illumination code that used to have "show reduced light radius while running" performance optimization. And it is running--and only runnning--where performance matters.
Just started up a 4.1.3-nightly game on angband.live and movement is noticably laggy. Even moving singular tiles takes more time than it should (and does in old variants) and running down a winding corridor takes seconds. I read phase door and my @ changed position, seeing a kobold in the darkness and then the (newly found) room appeared a few ms later, it was quite delayed. Similarly moving in and out of a lit room I can see the game updating the wall lighting in a very delayed fashion. This is with base delay 10 and movement delay 0.

Downloaded a local version and it seemed totally fine there though.

Edit: A couple things while playing necromancer: wielding a light should give a message saying it impacts spellcasting I think. Firing nether bolt at an undead produces no message and upon inspecting it (in this case a zombie kobold) it says that it "does not resist nether" despite being immune.

Last edited by clouded; August 3, 2019 at 03:59.
clouded is offline   Reply With Quote
Old August 3, 2019, 14:04   #325
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,932
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Nick View Post
On reflection, I think the best way to handle this whole idea is to create a point_set of the relevant grids (probably by making a new create_rectangle_point_set(), or something), and then iterate across the point_set.
But... code golfing aside, does it actually make the code more comprehensible? Seems like two loops, an inner and an outer, are really easy to understand...
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old August 3, 2019, 23:49   #326
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,786
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by takkaria View Post
But... code golfing aside, does it actually make the code more comprehensible? Seems like two loops, an inner and an outer, are really easy to understand...
Yeah, I'm thinking along those lines too (and Gwarl has been from the beginning). My basic guideline is "make the code look like it's describing the game world", and so I'm deciding which of the current two loops or "define this area, then do stuff to it" is more intuitive. And the fact that I'm still wondering probably means there's not enough difference to go through all the fuss
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 4, 2019, 06:46   #327
Sphara
Adept
 
Join Date: Oct 2016
Location: Finland
Posts: 186
Sphara is on a distinguished road
Half-Troll Blackguard's regeneration consumes food even when you're not wounded. Resting with already full HP consumes 1% in precisely 30 turns, exactly the same time it takes to lose when resting wounded. Eating one food ration keeps you fed about 500 turns before hunger penalties kick in. This no good.

I guess this is because Blackguard's innate regeneration penalty overlaps with Half-Troll's own regen all the time? Innate impaired HP-regen and infravision both show non-highlighted gray plus in character sheet.

It kinda makes sense Trolls needing to eat much, but for me, it's too much. Let me know if this is a bug or not. I won't touch Half Troll-Blackguard, if this is intentional.
Sphara is offline   Reply With Quote
Old August 4, 2019, 09:00   #328
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,786
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by Sphara View Post
Half-Troll Blackguard's regeneration consumes food even when you're not wounded. Resting with already full HP consumes 1% in precisely 30 turns, exactly the same time it takes to lose when resting wounded. Eating one food ration keeps you fed about 500 turns before hunger penalties kick in. This no good.

I guess this is because Blackguard's innate regeneration penalty overlaps with Half-Troll's own regen all the time? Innate impaired HP-regen and infravision both show non-highlighted gray plus in character sheet.

It kinda makes sense Trolls needing to eat much, but for me, it's too much. Let me know if this is a bug or not. I won't touch Half Troll-Blackguard, if this is intentional.
I don't think there are any bugs here, but let me clarify exactly what's happening:
  • Half-trolls get regen, which means an added 15 (food bar is 10000) digested every game turn (usual digestion per game turn is roughly 10+speed, so at normal speed digestion is more than doubled);
  • Blackguards get impaired HP regen, which stacked with Half-troll regen means a HT blackguard just gets normal speed regen;
  • All characters regenerate hitpoints faster the fuller they are;
  • HP makes no difference to digestion speed.

So HT blackguard gets fast digestion with no effect on regen. Slow digestion (which divides digestion by 5) is probably a good thing to have.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 4, 2019, 09:26   #329
Sphara
Adept
 
Join Date: Oct 2016
Location: Finland
Posts: 186
Sphara is on a distinguished road
Quote:
Originally Posted by Nick View Post
I don't think there are any bugs here, but let me clarify exactly what's happening:
  • Half-trolls get regen, which means an added 15 (food bar is 10000) digested every game turn (usual digestion per game turn is roughly 10+speed, so at normal speed digestion is more than doubled);
  • Blackguards get impaired HP regen, which stacked with Half-troll regen means a HT blackguard just gets normal speed regen;
  • All characters regenerate hitpoints faster the fuller they are;
  • HP makes no difference to digestion speed.

So HT blackguard gets fast digestion with no effect on regen. Slow digestion (which divides digestion by 5) is probably a good thing to have.
Ok, thanks for the answer.
For slow digestion: I have sDigest and it CERTAINLY did not divide the characters hunger rate by 5. Did you mean 2? I lost 1% in about every 60 turns of waiting and 1%/30 turns without it. This was tested by resting at 32% satiation level.
Sphara is offline   Reply With Quote
Old August 4, 2019, 11:39   #330
fph
Knight
 
Join Date: Apr 2009
Location: Berlin / Italy
Posts: 777
fph is on a distinguished road
I find out now that blackguards have ImpHP as an intrinsic. That seems an important drawback. Maybe it should be mentioned on the character creation screen?
__________________
Dive fast, die young, leave a high-CHA corpse.
--
You read a scroll labeled 'lol gtfo' of Teleport Level.
fph is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
First release Quirk Sil 18 November 14, 2017 22:45
3.4.0 Release Candidate is available fizzix Vanilla 111 July 5, 2012 12:39
3.2 release candidate is upon us! d_m Vanilla 147 January 19, 2011 10:10
Release HellBand 0.8.7 konijn_ Variants 4 December 27, 2009 04:14
reactions to changes in new V release will_asher Vanilla 50 April 9, 2008 18:47


All times are GMT +1. The time now is 12:05.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.