Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old August 27, 2021, 01:31   #51
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,172
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by Cuboideb View Post
I'm looking at every ocurrence of memset (I have the feeling that a large portion of the memory is wiped in some place). This line seems strange in ui-term.c (2626):

/* Assume no key */
memset(ch, 0, sizeof *ch);

It's valid ?
I think it's just zeroing the memory that's going to store a keypress, so it looks fine to me. Also it's been there for 10 years without causing a problem
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 27, 2021, 01:32   #52
Cuboideb
Adept
 
Join Date: May 2020
Location: Argentina
Posts: 182
Cuboideb is on a distinguished road
I had some problems with Android 10 concerning storage. I don't know if it's related to this.

There is a long standing bug in the android port that arises once in a while. A monster race pointer becomes null and the game crashes.

"...Google reports a lot of errors in mon_take_hit, get_lore, player_kill_monster. All related in some way to an invalid mon->race pointer..."

As I said, perhaps a rogue memset is wiping a chunk of memory.
Cuboideb is offline   Reply With Quote
Old August 27, 2021, 01:33   #53
Cuboideb
Adept
 
Join Date: May 2020
Location: Argentina
Posts: 182
Cuboideb is on a distinguished road
Quote:
Originally Posted by Nick View Post
I think it's just zeroing the memory that's going to store a keypress, so it looks fine to me. Also it's been there for 10 years without causing a problem
Sorry, I didn't know that sizeof could be used without parenthesis.
Cuboideb is offline   Reply With Quote
Old August 27, 2021, 02:07   #54
swim
Apprentice
 
Join Date: Mar 2021
Location: NL, Canada
Posts: 55
swim is on a distinguished road
Quote:
Originally Posted by Nick View Post
I am still not able to reproduce this crash, including with provided savefiles. It's very annoying.
Maybe this will help...

https://drive.google.com/file/d/1wbl...ew?usp=sharing

That's the full game directory including the save file.
swim is offline   Reply With Quote
Old August 27, 2021, 03:41   #55
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,172
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by swim View Post
Maybe this will help...

https://drive.google.com/file/d/1wbl...ew?usp=sharing

That's the full game directory including the save file.
Thank you. I can confirm that this crashes in Win 10, both in the directory you supplied and in a clean copy. Testing continues
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 27, 2021, 03:47   #56
swim
Apprentice
 
Join Date: Mar 2021
Location: NL, Canada
Posts: 55
swim is on a distinguished road
Quote:
Originally Posted by Nick View Post
Thank you. I can confirm that this crashes in Win 10, both in the directory you supplied and in a clean copy. Testing continues
Thank YOU!
I loved what I saw of the game so far.
swim is offline   Reply With Quote
Old August 27, 2021, 16:19   #57
Cuboideb
Adept
 
Join Date: May 2020
Location: Argentina
Posts: 182
Cuboideb is on a distinguished road
Nick, which compiler do you use for windows ?

If I put a fresh copy of the executable made with mingw (32 bits), the savefile provided by swim doesn't crash.

Last edited by Cuboideb; August 27, 2021 at 16:51.
Cuboideb is offline   Reply With Quote
Old August 27, 2021, 17:52   #58
backwardsEric
Adept
 
Join Date: Aug 2019
Posts: 219
backwardsEric is on a distinguished road
Quote:
Originally Posted by Cuboideb View Post
Nick, which compiler do you use for windows ?

If I put a fresh copy of the executable made with mingw (32 bits), the savefile provided by swim doesn't crash.
It's the mingw cross-compiler as picked up from the package, gcc-mingw-w64, in the ubuntu-18.04 runner on Gihub's Actions. configure was run with

Code:
env CFLAGS="-O2" ./configure --enable-release --enable-win --disable-curses --build=i686-pc-linux-gnu --host=i686-w64-mingw32
Because of Arralen's report of trouble with the Windows executable and Windows 8, have not been using the ubuntu-20.04 runner and its version of mingw.

Last edited by backwardsEric; August 27, 2021 at 18:05. Reason: referenced the wrong thread
backwardsEric is offline   Reply With Quote
Old August 28, 2021, 00:18   #59
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,172
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
The latest builds should not have the crash on moving house, thanks to backwardsEric for finding and fixing the bug.

It seems that someone had put some essential code inside an assert(), and then optimised out asserts in release builds...
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 28, 2021, 00:28   #60
swim
Apprentice
 
Join Date: Mar 2021
Location: NL, Canada
Posts: 55
swim is on a distinguished road
Excellent!
I'm going to give it a try right now!
swim is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
FAangband 1.3 Nick Variants 136 June 11, 2013 02:51
FAangband 1.2 Nick Variants 255 September 27, 2012 14:47
FAangband 1.1 Nick Variants 483 July 19, 2011 14:04
Towards FAangband 1.2 Nick Variants 54 March 17, 2011 19:39
FAangband 0.3.5 Nick Variants 145 March 2, 2009 06:31


All times are GMT +1. The time now is 00:56.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.