Code: Notes live where?

camlost · February 20, 2009, 21:08

Where is the standard place to store the notes (and autonotes) for a character? I think I found a patch that seems to store them externally, but I assume that it is more common to save it within the savefile.

Alternately, is there a GPL-compatible note/autonotes patch I can copy from?

Pete Mack · February 20, 2009, 21:43

I don't know about a patch, but V and FA store it in the savefile, and do not keep an external file during the game (as NPP does).

Nick · February 20, 2009, 21:44

That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.

camlost · February 20, 2009, 21:54

Quote:

Originally Posted by Nick

That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while.

FA is GPL, right? Is there a list of variants and licenses for those trying to lift code?

Nick · February 20, 2009, 22:11

Quote:

Originally Posted by camlost

FA is GPL, right?

Current version technically not, next one will be. That said, the notes stuff is taken from Jeff Greene's NPP implementation, and modified by me, and we're both signed up members of the GPL push, so I think you're clear. IIRC almost all the GPL-dubious stuff is in the main-xxx.c files, which are well away from any notes content. If you're in any doubt, use the V one.

February 20, 2009, 21:08	#1
camlost Sangband 1.x Maintainer Join Date: Apr 2007 Posts: 522	Code: Notes live where? Where is the standard place to store the notes (and autonotes) for a character? I think I found a patch that seems to store them externally, but I assume that it is more common to save it within the savefile. Alternately, is there a GPL-compatible note/autonotes patch I can copy from? __________________ a chunk of Bronze {These look tastier than they are. !E} 3 blank Parchments (Vellum) {No french novels please.}

February 20, 2009, 21:44	#3
Nick Vanilla maintainer Join Date: Apr 2007 Location: Canberra, Australia Age: 54 Posts: 7,860 Donated: $60	That patch is I suspect where NPP got it's implementation from (or vice versa). NPP originally stored the notes in a separate file, which had several problems. I don't know if there is a patch for the current V setup (although stuff was posted to the angband-dev mailing list). It should be fairly straightforward just to lift one of the current implementations, though - V and FA have good setups, I haven't checked NPP's in a while. __________________ One for the Dark Lord on his dark throne In the Land of Mordor where the Shadows lie.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Comp #61 notes	Donald Jonker	Competition	37	November 29, 2008 19:45
Notes Patch	Narvius	Vanilla	12	August 8, 2008 21:50
[ToME] Notes on a thaumaturgist build	Therem Harth	AAR	0	January 19, 2008 23:08
Looking through the code	K.I.L.E.R	Vanilla	5	July 11, 2007 09:01
The safe_setuid code	CJNyfalt	Vanilla	11	June 26, 2007 04:25

February 20, 2009, 21:43	#2
Pete Mack Prophet Join Date: Apr 2007 Location: Seattle, WA Posts: 5,414 Donated: $40	I don't know about a patch, but V and FA store it in the savefile, and do not keep an external file during the game (as NPP does).

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)