Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old August 1, 2011, 13:13   #1
Narvius
Knight
 
Narvius's Avatar
 
Join Date: Dec 2007
Location: Poland, Katowice
Age: 27
Posts: 589
Narvius is on a distinguished road
[3.3] Targetting using *

It used to select the nearest enemy by default, now it seems to go for the next-nearest.
Narvius is offline   Reply With Quote
Old August 1, 2011, 13:21   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Narvius View Post
It used to select the nearest enemy by default, now it seems to go for the next-nearest.
Interesting - you may have won the prize for First Genuine Bug in 3.3.0. AFAICT there were no intentional changes to targetting mechanics in 3.3's development, and the only change I can think of is the one to display the path-to-target (which we borrowed from NPP). There's no reason this should have changed the behaviour of '*' though, so it may be related to the input layer changes instead.

Grateful for confirmation of this bug from others, and also for a savefile from which it can be immediately reproduced.

Late thought - is it by any chance only ignoring mimics? The behaviour could be related to the mimic changes, unless it's demonstrably happening with no mimics in sight ...
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old August 1, 2011, 13:31   #3
Narvius
Knight
 
Narvius's Avatar
 
Join Date: Dec 2007
Location: Poland, Katowice
Age: 27
Posts: 589
Narvius is on a distinguished road
Savefile attached. It should target the bottom left orc, instead it targets the one above him (so, no, not mimic-related).

If it helps, Windows XP SP3, no tiles, with minor modifications to the prf files because I severely dislike the atrociously-coloured block walls.

Edit: Also, "target nearest" works as intended.
Attached Files
File Type: zip save.zip (14.4 KB, 74 views)

Last edited by Narvius; August 1, 2011 at 13:37.
Narvius is offline   Reply With Quote
Old August 1, 2011, 13:34   #4
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Grateful for confirmation of this bug from others, and also for a savefile from which it can be immediately reproduced.
Works well for me, so this isn't case for all copies.
Timo Pietilš is offline   Reply With Quote
Old August 1, 2011, 13:55   #5
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Narvius View Post
Savefile attached. It should target the bottom left orc, instead it targets the one above him (so, no, not mimic-related).

If it helps, Windows XP SP3, no tiles, with minor modifications to the prf files because I severely dislike the atrociously-coloured block walls.

Edit: Also, "target nearest" works as intended.
Hmm. Given your edit and Timo's comment (thanks Timo), I am now wondering whether '*' has ever explicitly looked for the shortest distance from @. Perhaps it just starts at the first monster in the list. I'll check with 3.2.0 to see if things have changed. (For this we need a 3.2.0 savefile, but it shouldn't be hard to arrange.)
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old August 1, 2011, 14:00   #6
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Hmm. Given your edit and Timo's comment (thanks Timo), I am now wondering whether '*' has ever explicitly looked for the shortest distance from @. Perhaps it just starts at the first monster in the list. I'll check with 3.2.0 to see if things have changed. (For this we need a 3.2.0 savefile, but it shouldn't be hard to arrange.)
What I did was getting between two townsfolk so that distance to one was 8 and other 9, then moved one step so that distances were reversed. '*' changed target just like it should do.

[EDIT] checked with attached savefile, and for me '*' does target bottom left orc, not the one above it.

[EDIT to EDIT] Both orcs are BTW 5 steps away from '@', so both are valid "nearest" targets. Might be random which one it chooses.

Last edited by Timo Pietilš; August 1, 2011 at 14:08.
Timo Pietilš is offline   Reply With Quote
Old August 1, 2011, 14:01   #7
Narvius
Knight
 
Narvius's Avatar
 
Join Date: Dec 2007
Location: Poland, Katowice
Age: 27
Posts: 589
Narvius is on a distinguished road
Did you try it with the savefile I provided?
(load up, *)

[Edit]
Okay. Now I'm in town, a drunk at 0N4E, and a beggar at 3N16W.
* targets the beggar, ' targets the drunk.

Weird.

Second try.
Cat at 1N1E, Cat#2 at 5S1E, beggar at 0N8W.
Selects Cat#2, which is incidentally the next-nearest target.

Attached: Situation @Second try.

[Second Edit]
I just redownloaded 3.3.0 off rephial and started a brand new character without any prior modifications to the game files. The problem persists, so it's not caused by any of my tinkering.
Attached Files
File Type: zip save.zip (12.2 KB, 83 views)

Last edited by Narvius; August 1, 2011 at 14:21.
Narvius is offline   Reply With Quote
Old August 1, 2011, 14:28   #8
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by Narvius View Post
Did you try it with the savefile I provided?
(load up, *)

[Edit]
Okay. Now I'm in town, a drunk at 0N4E, and a beggar at 3N16W.
* targets the beggar, ' targets the drunk.

Weird.

Second try.
Cat at 1N1E, Cat#2 at 5S1E, beggar at 0N8W.
Selects Cat#2, which is incidentally the next-nearest target.

Attached: Situation @Second try.

[Second Edit]
I just redownloaded 3.3.0 off rephial and started a brand new character without any prior modifications to the game files. The problem persists, so it's not caused by any of my tinkering.
Your savefiles work in my copy just fine, both of them. First one targeted the bottom left orc, second the nearest cat.

Maybe this has something to do with platform?? Mine is Win XP SP3.
Timo Pietilš is offline   Reply With Quote
Old August 1, 2011, 14:31   #9
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 39
Posts: 1,516
d_m is on a distinguished road
Quote:
Originally Posted by Narvius View Post
Okay. Now I'm in town, a drunk at 0N4E, and a beggar at 3N16W.
* targets the beggar, ' targets the drunk.
I will look into this more closely. I'm don't think that (') and (*) are expected to necessarily target the SAME closest monster, although maybe it would be nice if they were guaranteed to have the same behavior.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old August 1, 2011, 14:35   #10
Narvius
Knight
 
Narvius's Avatar
 
Join Date: Dec 2007
Location: Poland, Katowice
Age: 27
Posts: 589
Narvius is on a distinguished road
Well, that's at least what I'm used to.

Just to make sure my mind isn't playing tricks I tried it on 3.20 - works fine, the way I expect.
Narvius is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
targetting and LOS PowerDiver Vanilla 187 July 6, 2009 00:02
Targetting and LOS discussion wiki page PaulBlay Vanilla 60 June 28, 2009 03:42
targetting monsters in walls in DaJAngband will_asher Variants 1 June 27, 2009 09:24


All times are GMT +1. The time now is 17:48.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.