Tiny Display bug with 4.2

bron · September 23, 2019, 23:14

I'm playing in the current competition, and I notice something odd: my Priest character has cast Heroism, and this does show correctly in the status line at the bottom of the normal play screen, but in the character status screen where the resists (etc.) are shown, it does NOT have the expected '!' in the '@' slot of the 'pFear' line.

PowerWyrm · September 24, 2019, 09:23

Quote:

Originally Posted by bron

I'm playing in the current competition, and I notice something odd: my Priest character has cast Heroism, and this does show correctly in the status line at the bottom of the normal play screen, but in the character status screen where the resists (etc.) are shown, it does NOT have the expected '!' in the '@' slot of the 'pFear' line.

IIRC in the latest version, Heroism doesn't provide pFear anymore, just the AC and tohit boost. Same applies to Berserk. No idea if it's a bug or a feature.

bron · September 24, 2019, 10:17

Quote:

Originally Posted by PowerWyrm

IIRC in the latest version, Heroism doesn't provide pFear anymore

Humm .. if true, then the bug is in the documentation - the description of the Priestly "Heroism" spell says that it provides resistance to fear. I will say that my character has not been made afraid ever since I started running with Heroism on all the time, so it certainly *seems* like I'm getting pFear. OTOH, the character has a high saving throw (as of now, it's 100%, although it wasn't earlier), so maybe I just got really lucky (?)

Sphara · September 24, 2019, 17:20

Does pFear show after you've reached CL 20?

bron · September 24, 2019, 17:30

Quote:

Originally Posted by Sphara

Does pFear show after you've reached CL 20?

The character is CL41 at the moment, and there is no indication on the character status screen (as shown, e.g. in the char dump for Morin in competition 223). The "Browse" description of the Prayer is still the same, and the "Hero" indication is shown on the bottom of the main play screen.

bron · September 25, 2019, 07:15

Looking at calc_bonuses in player-calcs.c I see that both heroism (HERO) and berserk (SHERO) *do* set the PROT_FEAR flag. So it kinda looks like the original post was correct and this is just a (very minor) issue with the character status display.

bron · September 25, 2019, 07:51

So .. I'm no expert on the Angband code, but a quick look at it makes me think the problem is that in calc_bonuses, both p->timed[TMD_HERO] and p->timed[TMD_SHERO] set OF_PROT_FEAR directly, but display_resistance_panel in ui-player.c appears to use player->timed[TMD_BOLD] when figuring out whether or not to display the '!'

September 23, 2019, 23:14	#1
bron Swordsman Join Date: May 2008 Location: Saratoga, California (in the midst of Silicon Valley) Posts: 485	Tiny Display bug with 4.2 I'm playing in the current competition, and I notice something odd: my Priest character has cast Heroism, and this does show correctly in the status line at the bottom of the normal play screen, but in the character status screen where the resists (etc.) are shown, it does NOT have the expected '!' in the '@' slot of the 'pFear' line.

September 24, 2019, 17:20	#4
Sphara Adept Join Date: Oct 2016 Location: Finland Posts: 192	Does pFear show after you've reached CL 20? Attached Thumbnails

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[3.5.1] display bug?	Bogatyr	Vanilla	2	February 1, 2015 22:14
v3.5 tiny quiver bug	MattB	Vanilla	0	May 1, 2014 15:05
[3.5 dev] Tiny bug in dev 581 (permanent scrolls!)	Ingwe Ingweron	Vanilla	8	October 15, 2013 06:21
tiny little unimportant DJA bug that's been bugging me	will_asher	Development	7	November 30, 2009 20:21
Tiny 3.1 bug	Zikke	Vanilla	1	January 8, 2009 22:41

September 25, 2019, 07:15	#6
bron Swordsman Join Date: May 2008 Location: Saratoga, California (in the midst of Silicon Valley) Posts: 485	Looking at calc_bonuses in player-calcs.c I see that both heroism (HERO) and berserk (SHERO) do set the PROT_FEAR flag. So it kinda looks like the original post was correct and this is just a (very minor) issue with the character status display.

September 25, 2019, 07:51	#7
bron Swordsman Join Date: May 2008 Location: Saratoga, California (in the midst of Silicon Valley) Posts: 485	So .. I'm no expert on the Angband code, but a quick look at it makes me think the problem is that in calc_bonuses, both p->timed[TMD_HERO] and p->timed[TMD_SHERO] set OF_PROT_FEAR directly, but display_resistance_panel in ui-player.c appears to use player->timed[TMD_BOLD] when figuring out whether or not to display the '!'

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)