Bugs in 4.2.0

[wobbly]

Things that shield monsters from vampire strike:

gold
object
staircase

[DavidMedley]

Originally Posted by wobbly

Things that shield monsters from vampire strike:

gold
object
staircase

Yeah, I made a note of that as well. It's *anything* (as far as I can tell) including yourself. Also, the message to the player is not very precise. Took me a while to figure out what it actually meant - I thought it was a monster resistance. "There is no open space to attack from" might be better.

[wobbly]

inscribing @v1 doesn't work for throwing weapons

[scrarth]

Encountered a couple of bugs in a 4.2.0 game, played on a Windows 7 machine.

The first bug was encountered when targeting and then teleporting away Gothmog, and then casting the spell Single Combat on an enemy using a direction key (i.e. not targeting). This resulted in the error attached as angband_error1.jpg. After the game crashed and reloading the save I was in the Single Combat room with Gothmog, not the enemy I actually cast the spell on. Fortunately I was able to beat him, but it was definitely not a fight I was expecting.

Steps to reproduce
1. Target an enemy using * or '
2. Teleport away using the rod of teleport in inventory
3. Stand next to a different enemy and cast Single Combat, using an arrow key instead of * or '

Some time after this when I tried to book cast recall out of the dungeon, I get the error message attached in angband_error2.png (side note, why does the website upload the first as .jpg and the second as .png? They're both .pngs). I can't remember for sure but I think this was the first time I recalled since encountering the first bug, so the two might be related.

Steps to reproduce
1. Cast Recall from book

I've attached a savefile for convenience, both bugs are reproducible in it. I'd really appreciate it if the savefile could be fixed, hopefully the bugs aren't too hard to track down.

[Chud]

See other thread "You fail to harm ..." -- seems like it may be a bug.

[Nick]

Originally Posted by scrarth

Encountered a couple of bugs in a 4.2.0 game, played on a Windows 7 machine.

The first bug was encountered when targeting and then teleporting away Gothmog, and then casting the spell Single Combat on an enemy using a direction key (i.e. not targeting). This resulted in the error attached as angband_error1.jpg. After the game crashed and reloading the save I was in the Single Combat room with Gothmog, not the enemy I actually cast the spell on. Fortunately I was able to beat him, but it was definitely not a fight I was expecting.

Steps to reproduce
1. Target an enemy using * or '
2. Teleport away using the rod of teleport in inventory
3. Stand next to a different enemy and cast Single Combat, using an arrow key instead of * or '

Some time after this when I tried to book cast recall out of the dungeon, I get the error message attached in angband_error2.png (side note, why does the website upload the first as .jpg and the second as .png? They're both .pngs). I can't remember for sure but I think this was the first time I recalled since encountering the first bug, so the two might be related.

Steps to reproduce
1. Cast Recall from book

I've attached a savefile for convenience, both bugs are reproducible in it. I'd really appreciate it if the savefile could be fixed, hopefully the bugs aren't too hard to track down.

Thanks for the detailed report. I think I have an idea what caused it - Single Combat requires a targeted monster, and so it used the one you had previously targeted, which caused bad things to happen because he was out of LoS etc. I'll look at the savefile.

[DavidMedley]

I used Vampire Strike on creeping adamantite coins. Yummy!

I also was surprised that it was resistant to acid. Seems like the ideal weapon to use against metal.

[Derakon]

Adamantite, and mithril, are both corrosion-proof. That holds for armor made of the metal just as much as it does for monsters made of it.

[backwardsEric]

With 4.2.0 using the original tiles on Mac OS X, witches and blackguards are rendered as 'p's and slices of meat are rendered as ','s.

[backwardsEric]

Running 4.2.0 on a Mac and collecting a report of memory leaks from it with the Leaks instrument in XCode reported leaks of 32 or 240 bytes where the memory was allocated from this partial call stack (I've omitted the functions before process_command()):

mem_zalloc()
object_copy()
object_copy_amt()
store_sell()
store_menu_handle()
menu_select()
use_store()
event_signal()
move_player()
do_cmd_walk()
process_command()

There was also a leak of 32 bytes where the memory was allocated from this partial call stack:

mem_zalloc()
object_copy()
object_copy_amt()
do_cmd_stash()
process_command()

From the code, space may be allocated for slays/brands/curses in the temporary object used in either store_sell() or do_cmd_stash() but that space is not released before the temporary object falls out of scope. The attached file is a patch from git format-patch for store.c and ui-store.c to plug the leak.

object_info_ego() in obj-info.c and wiz_reroll_item() in wiz-debug.c also look like they could leak the memory for slays/brands/curses, but I didn't exercise those functions when profiling Angband with the Leaks instrument.