Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old April 8, 2009, 16:55   #1
PaulBlay
Knight
 
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
Rename /src/player/util.c ?

It's a small point, but some compilers dislike it when there are two files of the same name. The 'object' files have (for example) 'obj-util.c' so they're no problem, using a a similar approach you could change the util.c in /src/player/ to 'pla-util.c' or 'plyr-util.c'.
__________________
Currently turning (Angband) Japanese.
PaulBlay is offline   Reply With Quote
Old April 8, 2009, 17:05   #2
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by PaulBlay View Post
It's a small point, but some compilers dislike it when there are two files of the same name. The 'object' files have (for example) 'obj-util.c' so they're no problem, using a a similar approach you could change the util.c in /src/player/ to 'pla-util.c' or 'plyr-util.c'.
Really? Are you sure that the make rules are putting the object files in the right place? I started using subdirectories to avoid ridiculous names...
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old April 8, 2009, 17:14   #3
PaulBlay
Knight
 
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
Quote:
Originally Posted by takkaria View Post
Really? Are you sure that the make rules are putting the object files in the right place? I started using subdirectories to avoid ridiculous names...
Yes. Talking about Open Watcom in particular here (although I'm pretty sure I saw it in another compiler before). Although it says "\player\util.c" in the list of files to add, when you try to add the \util.c file the error message

Conflicting file 'player\util.c' found in target 'Angband65.exe'

is displayed.
__________________
Currently turning (Angband) Japanese.
PaulBlay is offline   Reply With Quote
Old April 8, 2009, 17:33   #4
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by PaulBlay View Post
Yes. Talking about Open Watcom in particular here (although I'm pretty sure I saw it in another compiler before). Although it says "\player\util.c" in the list of files to add, when you try to add the \util.c file the error message

Conflicting file 'player\util.c' found in target 'Angband65.exe'

is displayed.
*sigh* I'm not willing to change source code organisation to work around bad tools. Is there any chance you could file a bug report on it with the OpenWatcom people? I wasn't even aware Watcom existed anymore...
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old April 8, 2009, 17:56   #5
PaulBlay
Knight
 
Join Date: Jan 2009
Posts: 657
PaulBlay is on a distinguished road
Quote:
Originally Posted by takkaria View Post
Is there any chance you could file a bug report on it with the OpenWatcom people? I wasn't even aware Watcom existed anymore...
They are, but it looks like it's a bad choice anyway.

I've reported the bug to Open Watcom.

[EDIT] It looks like what the problem is is that it creates all .obj files in the base (/src) directory whether the source files were in a subdirectory or not. So it's a compiler error, I guess, not an IDE error as I thought.
__________________
Currently turning (Angband) Japanese.

Last edited by PaulBlay; April 8, 2009 at 18:11.
PaulBlay is offline   Reply With Quote
Old August 6, 2009, 15:32   #6
ekolis
Knight
 
ekolis's Avatar
 
Join Date: Apr 2007
Location: Cincinnati, OH, USA
Age: 37
Posts: 911
ekolis is on a distinguished road
Send a message via AIM to ekolis Send a message via MSN to ekolis Send a message via Yahoo to ekolis
Since the same issue is occurring with MSVC++ 2008 as well, perhaps you might reconsider your position on this, Takkaria?

edit: oh, wait, I just found a nifty feature in VC++... you can override the name of the obj file generated for a specific c file! Perhaps there is such a feature in OpenWatcom?
__________________
You read the scroll labeled NOBIMUS UPSCOTI...
You are surrounded by a stasis field!
The tengu tries to teleport, but fails!

Last edited by ekolis; August 6, 2009 at 15:37.
ekolis is offline   Reply With Quote
Old August 6, 2009, 15:36   #7
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by ekolis View Post
Since the same issue is occurring with MSVC++ 2008 as well, perhaps you might reconsider your position on this, Takkaria?
Maybe. I really don't understand how MSVC can be that bad, though. There must be other projects which have more than one file with the same name in different directories...
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old August 6, 2009, 19:32   #8
Sergio
Scout
 
Join Date: Aug 2009
Posts: 26
Sergio is on a distinguished road
There are two bugs in Connect for your issue with Visual C++. It's a bug, and while it works just fine in VS2005, it's broken in VS2008. Sadly, it won't be fixed any time soon (maybe VS10).

http://connect.microsoft.com/VisualS...dbackID=395521
http://connect.microsoft.com/VisualS...dbackID=368272
Sergio is offline   Reply With Quote
Old August 6, 2009, 20:52   #9
zaimoni
Knight
 
zaimoni's Avatar
 
Join Date: Apr 2007
Posts: 590
zaimoni is on a distinguished road
Quote:
Originally Posted by ekolis View Post
edit: oh, wait, I just found a nifty feature in VC++... you can override the name of the obj file generated for a specific c file! Perhaps there is such a feature in OpenWatcom?
Yes: have to use non-default makefile rules, but any vaguely aware make utility has this capability.
__________________
Zaiband: end the "I shouldn't have survived that" experience. V3.0.6 fork on Hg.
Zaiband 3.0.10 ETA Mar. 7 2011 (Yes, schedule slipped. Latest testing indicates not enough assert() calls to allow release.)
Z.C++: pre-alpha C/C++ compiler system (usable preprocessor). Also on Hg. Z.C++ 0.0.10 ETA December 31 2011
zaimoni is offline   Reply With Quote
Old August 6, 2009, 21:09   #10
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by ekolis View Post
Since the same issue is occurring with MSVC++ 2008 as well, perhaps you might reconsider your position on this, Takkaria?

edit: oh, wait, I just found a nifty feature in VC++... you can override the name of the obj file generated for a specific c file! Perhaps there is such a feature in OpenWatcom?
How do you do that? And how do you do it on the commandline?
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Unifying monster and player races, some thoughts CJNyfalt Variants 4 January 8, 2009 14:14
Yet another new player Sordino AAR 19 May 14, 2008 10:52
player ghosts daft Vanilla 10 April 27, 2008 17:20
Saving PLAYER.prf *where* under Windows? TJA Vanilla 2 August 16, 2007 23:32
[All] Protecting the @ from player stupidity. andrewdoull Variants 10 July 3, 2007 13:39


All times are GMT +1. The time now is 04:36.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.