Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old August 22, 2010, 23:14   #21
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
I'll look into this.

The code definitely has a problem there, although my compiler accepted it. The Term_text_sdl needs a proper declaration and there is also a mistake in the parameter list as it seems.

Thanks for letting me know about it! I'll try to clean that up.

Edit:

At the moment it appears to me that one can just comment these two lines. I think this this code is never executed, but I'm not sure.
main-sdl.c, line 1574f:

Code:
    errr static Term_text_sdl(int x, int y, int n, const byte *ap, const char *cp);
    Term_text_sdl(x, y, n, ap, cp);
My impression that it would fail anyways if executed because there are done bad things with pointers.

Once I have more time I'll look into this some more.
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Old August 23, 2010, 00:12   #22
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 38
Posts: 1,516
d_m is on a distinguished road
Commenting out those two lines got me past that error. Here's the new one:

Code:
Making all in src
make[1]: Entering directory `/home/erik/iso-angband-0_2_8_3/src'
gcc -DHAVE_CONFIG_H -I. -I. -I.     -g -O2 -fno-strength-reduce  -c main-x11.c
main-x11.c:2294:39: error: ../hajo_src/world_adaptor.h: No such file or directory
make[1]: *** [main-x11.o] Error 1
make[1]: Leaving directory `/home/erik/iso-angband-0_2_8_3/src'
It looks like this directory didn't get added to the zipfile.

I tried commenting it out but then the linking stage crashed (which may or may not be related).

Thanks for your help.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old August 23, 2010, 00:50   #23
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
The directory was renamed to "iso". I don't think the main-x11.c module still works. It was not used since the very first Iso-Angband versions anymore, and the directory was renamed later. The SDL module replaced the X11 module at some point and was used for both Linux and Windows builds since then.

I'm a bit puzzled that the makefile did try to compile main-x11.c. It should not do that.

I'm using this to call make:

Code:
cd src
make -f Makefile.isov-sdl
I think I got the problems with main-sdl.c sorted. I have added

Quote:
extern errr SDL_init_screen_cursor(Uint32 w, Uint32 h);
extern errr SDL_DrawCursor(SDL_Surface *dst, SDL_Rect *dr);

static errr Term_text_sdl(int x, int y, int n, byte a, cptr s);
Just below the other procedure declarations at the start of the file.

And I have changed the lines that triggered the compiler error to this:

Code:
static errr Term_pict_sdl(int x, int y, int n,  const byte *ap, const char *cp)
{
	term_data *td = (term_data*)(Term->data);

	if (!td->gt || !td->gt->face)
	{
		Term_text_sdl(x, y, n, *ap, cp);
	} else
I think the declaration inside Term_pict_sdl was a leftover from an older version where the procedure had a different signature.

I want to do some more tests, to be sure the changes have no bad effects. But I must get some sleep first.

Edit: I just noticed that the compiler call in your message differes from the one that my console shows:

Code:
gcc -Wall -O1 -pipe -g -D"USE_ISOV_SDL" -D"USE_ISOV"
-D"USE_TRANSPARENCY" -c main-sdl.c -o main-sdl.o
I'm just posting this because the defines are important to activate the right code blocks. Maybe there is more makefile confusion here.

Edit 2: The automake/autoconfig (?) code that came with the Angband 2.9.3 codebase most likely does not work with my sources. It is a remnant from my try to update the Angband 2.9.1 codebase to 2.9.3 and I haven't removed these files since I was not quite sure if they are needed. Actually I wanted to leave the Angband code as untouched as possible.
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem

Last edited by Hajo; August 23, 2010 at 01:10.
Hajo is offline   Reply With Quote
Old August 23, 2010, 01:39   #24
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 38
Posts: 1,516
d_m is on a distinguished road
OK, well I must have been doing something wrong.

I made the changes you specified to main-sdl.c and then ran that exact make command and everything turned out great.

One feature request would be an isometric number pad somewhere in a corner so that I could figure out which diagonal I need to use
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old August 23, 2010, 10:45   #25
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
Good to know that it finally worked

I'll include the adapted main-sdl.c in the next release.

The rotation of the numpad against the display confuses me at times too. I have tried to configure the keymap differently, but I didn't get it right. I must learn more about the ways Angband interprets key presses first. If I cannot get it it to work, then a compass with the numbers displayed for the directions might give a visual clue.
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Old August 23, 2010, 11:30   #26
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
I've assembled a new version. Besides a newly introduced image for cloaks, this version features signs for shop entrances. I always had troubles to memorize the 1-8 shop numbers, and the visual clues help me a lot:


Click for full size.

For Windows users, there is a precompiled executable included. Also two starting batch files, "start_small.bat" and "start_large.bat" which choose a smaller or larger font, and therefore start with a smaller or larger window.

Download:
http://www.funkelwerk.de/data/iso-an...nd-0_2_8_4.zip

Sources and images are included as well. I did some changes to main-sdl.c and I think it should compile for Linux, too, but I had no chance to test that yet (try Makefile.isov-sdl for the SDL based code).

Thanks, d_m, for testing the compile on Linux, and the report about the problem in main-sdl.c!

Known bugs and problems:
http://www.funkelwerk.de/forum/index.php?topic=197.0

If you find a new problem, please let me know. Particularly misconfigured images.
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Old August 24, 2010, 17:33   #27
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
I had this crash in the (l)ook function again. This time I was able to debug it, and it seems there were illegal memory reads in "target_set_interactive_prepare" in file xtra2.c

I assume this has been long fixed in current Angband versions. Also the xtra2.c file much different from the version that Angband 2.9.3 had ... also maybe the problem only happens with "center view on player" option.

Anyways. I think I finally could fix this, and the next release will have the fix.
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Old August 24, 2010, 22:53   #28
nppangband
NPPAngband Maintainer
 
Join Date: Dec 2008
Location: Stat Gain, Angband
Posts: 926
nppangband is on a distinguished road
The screenshots look amazing. This is truly great stuff. Well done.
nppangband is offline   Reply With Quote
Old August 25, 2010, 10:45   #29
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
Thanks, makes me happy to hear that

I did more testing in regard to the (l)ook function crash, and at least in the scenario where the crash had happened in my testing game it is gone since the change. I've released a new version with this fix and no other changes.

Download:
http://www.funkelwerk.de/data/iso-an...nd-0_2_8_5.zip
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Old September 1, 2010, 10:09   #30
Hajo
Adept
 
Hajo's Avatar
 
Join Date: Aug 2010
Posts: 142
Hajo is on a distinguished road
Progress has slowed down, which might have many reasons, but one of them is, that I have become a bit bored again with Angband. To counter that I've started to work on a personal Angband variant, but again, this leaves less time for Iso-Angband with the vanilla core.

But a few things were done, still. At least all images and the image configuration are shared between the projects, so progress in one is also progress for the other:

- Line archer/ranger image.
- Fixed novice paladin config.
- Slightly improved centipede image.
- Image config for edible mushrooms.
- Ball and chain image and config.
- Whip image and config.

Ball-and-Chain, Whip, Edible Mushroom:
__________________
I have a project problem? I have no project problem. I start a project, I work on it, it fails. No problem
Hajo is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Threaded view misery Magnate Oook! 3 November 29, 2009 16:36
Field of view jv123 Vanilla 10 May 15, 2009 23:18
A new view... no duplicate entries buzzkill Competition 2 January 4, 2009 16:34
Isometric on a Mac st.patrik Variants 7 August 28, 2008 14:50
Isometric Angband Peteuplink Variants 6 July 25, 2008 10:00


All times are GMT +1. The time now is 16:45.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.