Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old May 23, 2011, 13:58   #11
jens
Swordsman
 
Join Date: Apr 2011
Location: Göteborg, Sweden
Posts: 348
jens is on a distinguished road
Tinkered a bit more with this, seems the crash occurs whenever the kobold shaman casts a magic missile.

Made a new save just before the encounter. In the save file just walk north and walk around in the room until the kobold casts a magic missile. Have a bunch of the new and improved CLW, so it's quite safe :-)
Attached Files
File Type: zip Nimlanc - just before crash.zip (6.2 KB, 46 views)
jens is offline   Reply With Quote
Old May 23, 2011, 14:26   #12
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by jens View Post
Tinkered a bit more with this, seems the crash occurs whenever the kobold shaman casts a magic missile.

Made a new save just before the encounter. In the save file just walk north and walk around in the room until the kobold casts a magic missile. Have a bunch of the new and improved CLW, so it's quite safe :-)
That's odd, because I fixed a crash on magic missile earlier on in the spell refactor. Either I messed up and regressed somewhere, or it's a coincidence and it's a completely different problem.

Thanks for the savefile - I'll have a look this evening.
Magnate is offline   Reply With Quote
Old May 23, 2011, 14:39   #13
jens
Swordsman
 
Join Date: Apr 2011
Location: Göteborg, Sweden
Posts: 348
jens is on a distinguished road
So far it's crashed for me each time someone cast a magic missile on me, so guessing it is still buggy...
jens is offline   Reply With Quote
Old May 23, 2011, 15:28   #14
kaypy
Swordsman
 
Join Date: May 2009
Posts: 294
kaypy is on a distinguished road
I'm getting about the same: magic missile = destroy the world

I have seen it occasionally get the spell off without crashing, but it's 80% crashing so far...
kaypy is offline   Reply With Quote
Old May 23, 2011, 16:17   #15
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by kaypy View Post
I'm getting about the same: magic missile = destroy the world

I have seen it occasionally get the spell off without crashing, but it's 80% crashing so far...
Hmmm. Inconsistency makes bug hunting much harder, but if it happens 80% of the time it's probably going to be easy enough to find and fix.

Looks like there will be a new nightly out soon, as there's not much testing that can be done if magic missiles crash the game ...
Magnate is offline   Reply With Quote
Old May 23, 2011, 16:52   #16
kaypy
Swordsman
 
Join Date: May 2009
Posts: 294
kaypy is on a distinguished road
Been doing some digging.

Should monster_learn_resists or update_smart_learn abort where
gf_ptr->resist
gf_ptr->immunity
or
gf_ptr->vuln
is null?

Because as near as I can tell, when that null goes into FLAG_OFFSET(flag) we get a negative-wraparound on the unsigned flag_offset which is what causes the crash.
kaypy is offline   Reply With Quote
Old May 23, 2011, 20:37   #17
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by kaypy View Post
Been doing some digging.

Should monster_learn_resists or update_smart_learn abort where
gf_ptr->resist
gf_ptr->immunity
or
gf_ptr->vuln
is null?

Because as near as I can tell, when that null goes into FLAG_OFFSET(flag) we get a negative-wraparound on the unsigned flag_offset which is what causes the crash.
Excellent, thank you - that explains the regression. Last time I had to add the nullness check to check_for_resist, this time it needs adding to update_smart_learn.

I'm not sure why the assertion failure was in z-bitflag.c though, when there was already an assert in update_smart_learn itself. Compiler optimisation, I guess.

Anyway, a new nightly should be out in a couple of hours. Thanks for the catch.
Magnate is offline   Reply With Quote
Old May 24, 2011, 00:56   #18
myshkin
Angband Devteam member
 
Join Date: Apr 2007
Posts: 334
myshkin is on a distinguished road
Yet another build

Fixes for the tunneling bug that kaypy reported and for the magic missile crash that jens reported are now on their way to the next dev release. Note that the one marked ef9e70e6dc still has some problems; you'll want the one marked 31b20dac9b. It should be up in a couple hours. The only other changes from the 22 May 2011 release are the Mac OS X accented characters fix, some tweaks to level feelings, and a more sensible message at death about keeping randarts.
myshkin is offline   Reply With Quote
Old May 24, 2011, 00:59   #19
kaypy
Swordsman
 
Join Date: May 2009
Posts: 294
kaypy is on a distinguished road
Quote:
Originally Posted by Magnate View Post
I'm not sure why the assertion failure was in z-bitflag.c though, when there was already an assert in update_smart_learn itself. Compiler optimisation, I guess.
The assert used to be assert(what >= 0), which wouldn't catch the null...
kaypy is offline   Reply With Quote
Old May 24, 2011, 04:45   #20
SSK
Adept
 
Join Date: Apr 2011
Posts: 111
SSK is on a distinguished road
Quote:
Originally Posted by Timo Pietilä View Post
I disagree on both counts. Even +5 to dam +5 power beats both Fingolfin and Cambeleg. Cestus having innate combat bonus is new addition. They are also relatively common, common enough that you find several during single game. Cambeleg/Fingolfin needs to be able to compete with those and they both do that by doing just what you said, Cambeleg giving +2 to CON and Fingolfin giving +4 DEX as well as FA. However they also need to have big combat bonuses, otherwise they are not worth using. +8 and +10 are good numbers for both of them, less makes them too inferior to high-end egos. If something you could make them a bit more rare (not much though, that too is pretty on spot currently).

These two artifacts are top artifacts, so they need to beat egos in most combinations. And be relatively rare. Otherwise there is no "Wohoo!" -effect. Other artifact gloves are not that important.
Totally agree With Timo.

Cambeleg and FIngolfin are top artifacts--I want to see these restored.
Same with the rings of power--I totally welcomed their recent boosting in speed and damage because in my mind they always had trouble competing with rings of speed, when they really ought to be something special--tip top artifacts.

I sort of disagree stripping speed from Gondor--in my current game I totally don't find Gondor a no-brainer over Dor-Lomin because of the letter's telepathy. Gondor is a top artifact.

If you want to tone down Elessar, Numenor, Haradrim, and Hammerhand that is totally reasonable--Haradrim is a new nontraditional artifact anyway, and I really don't like all these artifacts of evil no-class Harad being so powerful relative to the far more glorious Elven, Dwaven, Westernesse, and Godly origin stuff--the Haradrim just weren't portrayed as that powerful. Elessar--well, it's kind a newish anyway and I think a bit too powerful, but how about toning doen a *little*--stripping speed and removing all 7 damage is too much. Hammerhand--well, +9/+9 is too powerful especially as Helm Hammerhand just wasn't godlike, though he is certainly remembered fondly by the Rohirrim. So take it down a bit *but* also get rid of *aggravates*--it will at least be useful then.

I won't be downloading this development version.
SSK is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
5 May 2011 development release(s) myshkin Vanilla 84 May 23, 2011 16:43
MUD development Whelk Idle chatter 11 January 9, 2011 01:03
Is development *too* active? the Invisible Stalker Vanilla 14 December 26, 2010 17:47
Help start development Kurogane Idle chatter 17 October 28, 2010 07:03
[FA] FAangband development Nick Variants 174 May 30, 2008 02:02


All times are GMT +1. The time now is 04:25.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.