Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old August 21, 2011, 13:36   #21
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 7,733
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by Timo Pietilš View Post
I prefer Ainur. Slaad doesn't say anything to me. Sounds like erroneous writing of salad. I'm no going to fight cabbage.
Plus the point is to have non-evil things, and cabbage is evil.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old August 21, 2011, 17:29   #22
nppangband
NPPAngband Maintainer
 
Join Date: Dec 2008
Location: Stat Gain, Angband
Posts: 926
nppangband is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Correct. Takkaria is currently on vacation, but we can ask for a decision afterwards. The best way to do this is for somebody to put a new version of monster.txt on github and submit a "pull request" titled "New names for angels", or similar. Then any of the devteam can simply say "takkaria: ok for me to merge pull request #xyz?", with a link to the details of the proposed changes.

In case anyone is interested, this is the best way to get anything changed in the game.
NPP (thanks to Anssi Ralema) has already replaced Angels with Ainur. I will by happy to put together a patch for this if Takkaria wants the change (In addition to monster.txt, there are summon angel spells in the source code and in various tables like the knowledge screens that need to be re-done as well)
nppangband is offline   Reply With Quote
Old August 21, 2011, 22:04   #23
Max Stats
Swordsman
 
Join Date: Jun 2010
Posts: 324
Max Stats is on a distinguished road
Quote:
Originally Posted by relic View Post
The Giant Cabbage hits you -more
The Giant Cabbage envelopes you -more
You Die -more
Looks like you just fell victim to Cole's Law.
Max Stats is offline   Reply With Quote
Old August 21, 2011, 22:38   #24
relic
Apprentice
 
relic's Avatar
 
Join Date: Oct 2010
Location: Sweden
Posts: 76
relic is on a distinguished road
Quote:
Originally Posted by Max Stats View Post
Looks like you just fell victim to Cole's Law.
Ouch. That pun was so bad that it was really good.
relic is offline   Reply With Quote
Old August 22, 2011, 02:39   #25
fizzix
Prophet
 
Join Date: Aug 2009
Location: Madison, Wisconsin, US
Posts: 3,002
fizzix is on a distinguished road
Quote:
Originally Posted by nppangband View Post
NPP (thanks to Anssi Ralema) has already replaced Angels with Ainur. I will by happy to put together a patch for this if Takkaria wants the change (In addition to monster.txt, there are summon angel spells in the source code and in various tables like the knowledge screens that need to be re-done as well)
won't a find-replace of the word 'angel' with 'ainur' work on a first go?
fizzix is offline   Reply With Quote
Old August 22, 2011, 05:54   #26
Jungle_Boy
Swordsman
 
Join Date: Nov 2008
Posts: 434
Jungle_Boy is on a distinguished road
Quote:
Originally Posted by fizzix View Post
won't a find-replace of the word 'angel' with 'ainur' work on a first go?
Not on things like archons, and cherubim. There may be other angels without the word angel in their name as well but those are what I could think of right away.
__________________
My first winner: http://angband.oook.cz/ladder-show.php?id=10138
Jungle_Boy is offline   Reply With Quote
Old August 22, 2011, 06:52   #27
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,830
Derakon is on a distinguished road
He was talking about the source code, not the monster.txt file.
Derakon is offline   Reply With Quote
Old August 22, 2011, 10:17   #28
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by nppangband View Post
NPP (thanks to Anssi Ralema) has already replaced Angels with Ainur. I will by happy to put together a patch for this if Takkaria wants the change (In addition to monster.txt, there are summon angel spells in the source code and in various tables like the knowledge screens that need to be re-done as well)
Takkaria is keen (see 17th Aug reply further down the thread), so a patch would be gratefully accepted.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old August 22, 2011, 11:01   #29
Antoine
Ironband/Quickband Maintainer
 
Join Date: Nov 2007
Posts: 1,008
Antoine is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Takkaria is keen (see 17th Aug reply further down the thread), so a patch would be gratefully accepted.
I'd love to see the Angels to Ainur change made, but wasn't Takkaria agreeing to a simple renaming without gameplay changes?

A.
__________________
Ironband - http://angband.oook.cz/ironband/
Antoine is offline   Reply With Quote
Old August 22, 2011, 13:29   #30
nppangband
NPPAngband Maintainer
 
Join Date: Dec 2008
Location: Stat Gain, Angband
Posts: 926
nppangband is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Takkaria is keen (see 17th Aug reply further down the thread), so a patch would be gratefully accepted.
Will do. Is there any particular version/branch of the Angband source I should be working from?

The patch I do will have all of the NPP Ainur, so all angels will be replaced, and there will be probably about 20 new monsters for your review. I am tileset challenged, so I won't attempt to update the graphics. But that is probably best held off until you all decide which ones you want to use.

To answer that other question, about the source being a simple search/replace, there are a couple things involving summoning and monster spellcasting that need to be verified. There are always a couple unexpected issues, even in simple changes like this.
nppangband is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
TERM_XTRA_NOISE, candidate for removal. CJNyfalt Development 0 July 19, 2011 11:06
My un suggestions Adley Variants 14 December 12, 2010 16:50
suggestions/enhancements fbas Development 19 October 30, 2010 23:24
Improvement suggestions? dhegler Vanilla 4 November 4, 2009 03:10
Suggestions for my next char? NeoWizard Vanilla 5 January 22, 2009 21:12


All times are GMT +1. The time now is 09:23.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.