Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old August 11, 2011, 19:27   #1
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Oh no, I've caused an intermittent bug

So I'm trying to bring stat restore potions back to Angband 3.3.0. The code is all there, so I just put the potion entries in object.txt... And now Angband quits on start with this message:

Code:
Unable to (re-)stock store 4. Please report this bug
It looks like store 4 is the Alchemist. Do some Googling... Hey, maybe the presence of stat restore potions there is hard coded, and there are too many entries? So I try removing some items from the Alchemist's store.

And it works... Once. Then Angband continues to crash on start.

What's going on? Have I found some lower level problem in the code, or did I do something dumb?

Edit: dang it this is in the wrong forum. Can someone move this to Development?

Last edited by Therem Harth; August 11, 2011 at 19:52. Reason: Wrong forum
Therem Harth is offline   Reply With Quote
Old August 13, 2011, 04:26   #2
myshkin
Angband Devteam member
 
Join Date: Apr 2007
Posts: 334
myshkin is on a distinguished road
Quote:
Originally Posted by Therem Harth View Post
So I'm trying to bring stat restore potions back to Angband 3.3.0. The code is all there, so I just put the potion entries in object.txt... And now Angband quits on start with this message:
What N: and I: lines did you use for the potions?
myshkin is offline   Reply With Quote
Old August 13, 2011, 15:13   #3
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
326 to 331 and 75:17 to 75:22, respectively.
Therem Harth is offline   Reply With Quote
Old August 14, 2011, 21:07   #4
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
... Bizarre. I've deleted everything and checked out the git repo again, and now everything works fine. Darned if I can explain it.
Therem Harth is offline   Reply With Quote
Old August 14, 2011, 23:25   #5
Tobias
Adept
 
Tobias's Avatar
 
Join Date: Dec 2009
Posts: 172
Tobias is on a distinguished road
Quote:
Originally Posted by Therem Harth View Post
... Bizarre. I've deleted everything and checked out the git repo again, and now everything works fine. Darned if I can explain it.
maybe you just had to make distclean. That happens sometimes.
__________________
My Angband videos : http://www.youtube.com/view_play_lis...385E85F31166B2
Tobias is offline   Reply With Quote
Old October 17, 2011, 03:22   #6
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Uh oh, here we go again...

I removed stat restore potions from the Alchemist's in 3.2.0, and changed the number of slots from 32 to 26, as appropriate... And now, nine times out of ten, the SDL interface freezes on character generation, with no console output. I tried inducing the crash under GDB and got nothing at all - as far as GDB can tell, Angband continues to run normally while its interface is completely unresponsive.

Help?

Edit: and this is with a completely clean compile FWIW.
Therem Harth is offline   Reply With Quote
Old October 17, 2011, 03:28   #7
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Okay, I managed to get a backtrace with the X11 frontend. Can't C&P it, too big for the xterm, but it said something about a "double free or corruption" near the top.

GDB unfortunately still produces no output..
Therem Harth is offline   Reply With Quote
Old October 17, 2011, 11:32   #8
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,850
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Therem Harth View Post
Uh oh, here we go again...

I removed stat restore potions from the Alchemist's in 3.2.0, and changed the number of slots from 32 to 26, as appropriate... And now, nine times out of ten, the SDL interface freezes on character generation, with no console output. I tried inducing the crash under GDB and got nothing at all - as far as GDB can tell, Angband continues to run normally while its interface is completely unresponsive.

Help?

Edit: and this is with a completely clean compile FWIW.
The store stocking logic is fiendish and not very good - you've just run into one of its limitations. Don't reduce the number of slots, increase how many slots other items get to compensate and you should be fine.
__________________
"Physician, heal thyself."
takkaria is online now   Reply With Quote
Old October 17, 2011, 15:10   #9
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Ah, thanks. I'll see how that works.

Edit: nope, still crashes with the "double free or corruption (!prev)" error.
Therem Harth is offline   Reply With Quote
Old October 17, 2011, 21:24   #10
Therem Harth
Knight
 
Therem Harth's Avatar
 
Join Date: Jan 2008
Location: https://gitlab.com/miramor
Posts: 889
Therem Harth is on a distinguished road
Hah, this gets even better. It turns out that, if it crashes and you close it, Angband sticks around until you kill -9 it. I'm guessing GDB isn't telling me anything because the game is actually in an infinite loop; and the backtrace I got (with "double free or corrupion") isn't worth anything.

Perhaps I should switch to the 3.3 codebase?
Therem Harth is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +1. The time now is 11:42.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.