Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old September 28, 2008, 10:51   #1
andrewdoull
Unangband maintainer
 
andrewdoull's Avatar
 
Join Date: Apr 2007
Location: Sydney, Australia
Age: 48
Posts: 872
andrewdoull is on a distinguished road
[Un] Line endings - Windows or Unix?

Thoughts please...

I'm not particular, because I use Eclipse, which supports conversion from one to the other.

My hunch is windows, because it lowers the bar to contribute...
__________________
The Roflwtfzomgbbq Quylthulg summons L33t Paladins -more-
In UnAngband, the level dives you.
ASCII Dreams: http://roguelikedeveloper.blogspot.com
Unangband: http://unangband.blogspot.com
andrewdoull is offline   Reply With Quote
Old September 28, 2008, 12:06   #2
Bandobras
Knight
 
Join Date: Apr 2007
Posts: 726
Bandobras is on a distinguished road
My emacs supports both and conversion, so no problem for me. I don't know about vi. If we move to CRLF, we should convert all edit and help files --- here is where low-end contributions are most likely to be high-end in quality, as was the case with the options help file by Anne. Or perhaps only move to CRLF in text files and leave *.c in the standard C, that is Unix, format?
Bandobras is offline   Reply With Quote
Old September 28, 2008, 14:45   #3
Atarlost
Swordsman
 
Join Date: Apr 2007
Posts: 441
Atarlost is on a distinguished road
wordpad can handle unix line endings and saves as windows text. I've never moved text files the other direction so I can't speak to that. Vi might not handle windows text, but I'd be surprised if Vim doesn't and that's the version that comes with most linuxes. I'd have to reboot to check, though, and I'm too lazy.
__________________
One Ring to rule them all. One Ring to bind them.
One Ring to bring them all and in the darkness interrupt the movie.
Atarlost is offline   Reply With Quote
Old September 28, 2008, 16:37   #4
Blackened
Rookie
 
Blackened's Avatar
 
Join Date: Oct 2007
Location: Czech Republic
Age: 38
Posts: 18
Blackened is on a distinguished road
Quote:
Originally Posted by Bandobras View Post
My emacs supports both and conversion, so no problem for me. I don't know about vi. []
There is no problem with different line ends in Vim either, nor is the conversion. I wonder, is anyone really still coding in old vi?
Blackened is offline   Reply With Quote
Old September 28, 2008, 20:08   #5
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,951
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by andrewdoull View Post
Thoughts please...

I'm not particular, because I use Eclipse, which supports conversion from one to the other.

My hunch is windows, because it lowers the bar to contribute...
Why not use the svn:eol-style property in the repository so if you check out on Unix, you get LF, and on Windows, you get CRLF? That makes life easier for everyone.
takkaria is offline   Reply With Quote
Old September 28, 2008, 20:30   #6
Bandobras
Knight
 
Join Date: Apr 2007
Posts: 726
Bandobras is on a distinguished road
Quote:
Originally Posted by takkaria View Post
Why not use the svn:eol-style property in the repository so if you check out on Unix, you get LF, and on Windows, you get CRLF? That makes life easier for everyone.
Pretty wise, but it assumes people are able to use SVN. Some don't and they just download the sources zip. I wonder what unzip does with line endings on various OSes and what line endings you have to feed to zip...

About svn:eol-style, indeed some files don't have it. It may be borked due to import from CVS, I don't know. E.g.
Code:
svn proplist src/option.c
shows nothing and so gets the Windows line endings even on Linux. Most other files are OK.
Bandobras is offline   Reply With Quote
Old September 28, 2008, 21:51   #7
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,951
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Bandobras View Post
Pretty wise, but it assumes people are able to use SVN. Some don't and they just download the sources zip. I wonder what unzip does with line endings on various OSes and what line endings you have to feed to zip...
unzip -aL converts line endings. However, it would just be better to package the Windows source as a zip with CRLF and source for other platforms as a tar.bz2/gz with LF endings. I would assume that since this thread is about "lowering the cost of contribution", then it's mostly about SVN-- maybe I'm wrong.

Quote:
About svn:eol-style, indeed some files don't have it. It may be borked due to import from CVS, I don't know. E.g.
Code:
svn proplist src/option.c
shows nothing and so gets the Windows line endings even on Linux. Most other files are OK.
I should have just fixed this.
takkaria is offline   Reply With Quote
Old September 28, 2008, 22:48   #8
andrewdoull
Unangband maintainer
 
andrewdoull's Avatar
 
Join Date: Apr 2007
Location: Sydney, Australia
Age: 48
Posts: 872
andrewdoull is on a distinguished road
Quote:
Originally Posted by Bandobras View Post
Pretty wise, but it assumes people are able to use SVN. Some don't and they just download the sources zip. I wonder what unzip does with line endings on various OSes and what line endings you have to feed to zip...

About svn:eol-style, indeed some files don't have it. It may be borked due to import from CVS, I don't know. E.g.
Code:
svn proplist src/option.c
shows nothing and so gets the Windows line endings even on Linux. Most other files are OK.
Which I accidentally converted from Unix line endings as a part of a commit the other day.

It seems whomever contributed the original option.c file to the tree forgot to set up the svn property list for this file. They may need some svn training...

Sounds like the consensus is Windows + set up the properties correctly.

Andrew
__________________
The Roflwtfzomgbbq Quylthulg summons L33t Paladins -more-
In UnAngband, the level dives you.
ASCII Dreams: http://roguelikedeveloper.blogspot.com
Unangband: http://unangband.blogspot.com
andrewdoull is offline   Reply With Quote
Old September 29, 2008, 00:30   #9
Bandobras
Knight
 
Join Date: Apr 2007
Posts: 726
Bandobras is on a distinguished road
Quote:
Originally Posted by andrewdoull View Post
It seems whomever contributed the original option.c file to the tree forgot to set up the svn property list for this file. They may need some svn training...
Ahem. That said noble person might have thought, that our SVN repository is set up to add the property by default to every file. Myself, I'm not sure if and how such defaults can be set for a repository. Anyway, svn propset is cheap, it can even run recursively, but beware of breaking binary files via strange properties.

Quote:
Originally Posted by andrewdoull View Post
Sounds like the consensus is Windows + set up the properties correctly.
Agreed.

I'd say windows-style sources are enough, because non-Windows people are likely to be able to master SVN, while the people that contribute only documentation or game content (e.g. dungeon descriptions) are likely to run Wingdows, SVN or not.
Bandobras is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Windows v3.0.9 hanging? JustinH Vanilla 1 August 27, 2008 14:30
Opening a savefile in Windows Zero Vanilla 13 June 28, 2008 05:55
Terms/Additional Windows Rimmer Vanilla 4 March 30, 2008 15:56
Tolkien Estate v New Line Cinema Dragonboneman Idle chatter 1 February 12, 2008 16:39
Linux/Unix users: Where should savefiles be stored? takkaria Vanilla 34 November 3, 2007 11:36


All times are GMT +1. The time now is 02:29.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2023, vBulletin Solutions Inc.