Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old February 26, 2020, 08:10   #191
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,730
PowerWyrm is on a distinguished road
Quote:
Originally Posted by wobbly View Post
Bit of a stupid question from someone not very Git savy: How do I create a pull request? If I just push to origin from my local copy will that automatically do it?
I use Tortoise Git and after pressing "commit" then "push" you get another option to create a pull request.
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is online now   Reply With Quote
Old February 26, 2020, 10:11   #192
fph
Knight
 
Join Date: Apr 2009
Location: Berlin / Italy
Posts: 817
fph is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
I use Tortoise Git and after pressing "commit" then "push" you get another option to create a pull request.
As far as I understand, there are two separate things called a "pull request", which creates confusion.

In principle, a "pull request" in Git is nothing more than an exchange of messages between two humans: "hey, maintainer, could you please pull this revision from this repo?". It is not automated, and there is no specific format o protocol to send it. Git has a command `git request-pull` that pretty-prints a sample message to stdout with all the details of the revision to pull, but you still have to send it to the maintainer via mail or any other method.

However, Github (the hosting site) introduced a more streamlined process: as long as both repos are hosted on Github (and one has been created with the "fork" button on Github), you can click a button on their website to request a pull from the forker to the forkee (is that a word?). Github displays it on a nice page, with a "merge" button and a comment thread, and notifies the maintainer. So the main way to create a Github PR is online, from within Github's website. Nowadays, in my experience, when people talk about a PR they talk about a Github one.

I am not sure which one the button in Tortoise does, but I suspect it's the former.
__________________
Dive fast, die young, leave a high-CHA corpse.
--
You read a scroll labeled 'lol gtfo' of Teleport Level.
fph is offline   Reply With Quote
Old February 26, 2020, 16:22   #193
wobbly
Veteran
 
Join Date: May 2012
Location: Adelaide, Australia
Posts: 2,252
wobbly is on a distinguished road
Quote:
Originally Posted by fph View Post
As far as I understand, there are two separate things called a "pull request", which creates confusion.

In principle, a "pull request" in Git is nothing more than an exchange of messages between two humans: "hey, maintainer, could you please pull this revision from this repo?". It is not automated, and there is no specific format o protocol to send it. Git has a command `git request-pull` that pretty-prints a sample message to stdout with all the details of the revision to pull, but you still have to send it to the maintainer via mail or any other method.

However, Github (the hosting site) introduced a more streamlined process: as long as both repos are hosted on Github (and one has been created with the "fork" button on Github), you can click a button on their website to request a pull from the forker to the forkee (is that a word?). Github displays it on a nice page, with a "merge" button and a comment thread, and notifies the maintainer. So the main way to create a Github PR is online, from within Github's website. Nowadays, in my experience, when people talk about a PR they talk about a Github one.

I am not sure which one the button in Tortoise does, but I suspect it's the former.
Thanks, I got this to work
wobbly is offline   Reply With Quote
Old February 27, 2020, 06:18   #194
Sinquen
Rookie
 
Join Date: Feb 2015
Location: USA
Posts: 4
Sinquen is on a distinguished road
Multiple Beorn kills

As mentioned earlier with Quaker, uniques may come back after getting killed, even though they are listed as "dead" in monster knowledge. My current druid character killed Beorn 3 times on consecutive levels - 1400', 1450' and 1500'. Recalled to town after each level, if I remember correctly.

Haven't seen him since, so he's probably gone for good now.
Sinquen is offline   Reply With Quote
Old February 27, 2020, 08:21   #195
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,730
PowerWyrm is on a distinguished road
Quote:
Originally Posted by Sinquen View Post
As mentioned earlier with Quaker, uniques may come back after getting killed, even though they are listed as "dead" in monster knowledge. My current druid character killed Beorn 3 times on consecutive levels - 1400', 1450' and 1500'. Recalled to town after each level, if I remember correctly.

Haven't seen him since, so he's probably gone for good now.
That's because the unique can be used as a shapechange form for other mobs, which doesn't care about the unique being dead.
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is online now   Reply With Quote
Old February 27, 2020, 11:40   #196
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 54
Posts: 8,057
Donated: $60
Nick will become famous soon enough
Quote:
Originally Posted by PowerWyrm View Post
That's because the unique can be used as a shapechange form for other mobs, which doesn't care about the unique being dead.
I hope that's it, but being dead in monster knowledge is a worry.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old February 27, 2020, 22:36   #197
Sinquen
Rookie
 
Join Date: Feb 2015
Location: USA
Posts: 4
Sinquen is on a distinguished road
Fox form blows per round

Another possible issue - Fox Form is getting more rather than fewer blows per round, even though the character attributes screen shows -Blows. Original form using Dagmor is 3.6 blows/round, and Fox Form gets 5.3 blows/round, resulting in significantly more damage output.

That's according to the displayed weapon stats, and testing seems to confirm, as switching to Fox Form allows noticeably quicker kills of multi-hued dragons and such.

Pukel-man form gets 4.3 blows/round, an increase which seems appropriate due to the +4 STR bonus, and Eagle Form gets the same number of blows as original form, which also seems appropriate. So it's only Fox Form that seems unexpected (haven't tested Bear Form yet).
Sinquen is offline   Reply With Quote
Old February 28, 2020, 08:18   #198
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,730
PowerWyrm is on a distinguished road
Quote:
Originally Posted by Nick View Post
I hope that's it, but being dead in monster knowledge is a worry.
The unique is dead in that case. It's just that the Maia that can shapechange into Quaker just tries to impersonate a dead Quaker. Seems fine to me...
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is online now   Reply With Quote
Old February 28, 2020, 20:26   #199
quarague
Swordsman
 
Join Date: Jun 2012
Posts: 250
quarague is on a distinguished road
Got a minor display error here. Log of events:
You see a sling .. {??}
You have a sling .. {??}
You were holding a Long Bow
You have learned the rune of shooting speed.
You have a Sling of Extra Shots
Your bow tingles in your hands [wait what? it's a sling]
You are shooting with a Sling of Extra Shots

Character is a ranger if that matters.
quarague is offline   Reply With Quote
Old February 28, 2020, 21:23   #200
Sinquen
Rookie
 
Join Date: Feb 2015
Location: USA
Posts: 4
Sinquen is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
The unique is dead in that case. It's just that the Maia that can shapechange into Quaker just tries to impersonate a dead Quaker. Seems fine to me...
Can't speak for the other game, but in my game, it acted exactly like Beorn, switching forms with each form behaving differently ("p" form had normal speed and "q" form moved quickly for example). Also, there are multiple Beorn kills in player history, as shown in the attached image.
Attached Thumbnails
Click image for larger version

Name:	2b.jpg
Views:	10
Size:	17.5 KB
ID:	1798  
Sinquen is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Bugs with 3.5 donalde Vanilla 10 February 24, 2014 17:28
Bugs: V3.1.2 Pete Mack Vanilla 34 December 1, 2010 17:18
Bugs Adley Development 2 October 10, 2010 21:11
V bugs (3.1.1) Pete Mack Vanilla 3 January 10, 2010 09:02
V 3.9 Bugs momo125 Vanilla 3 September 11, 2007 15:48


All times are GMT +1. The time now is 15:49.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.