Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old February 4, 2013, 23:33   #1
Blue Baron
Adept
 
Join Date: Apr 2011
Posts: 103
Blue Baron is on a distinguished road
X11 Tile Support

A long time ago, in an IRC dev meeting, I volunteered to re-add X11 tile support to Angband.

I've rewritten X11 tile support, adding PNG support, in my personal fork of Z+Angband. I think my changes are GPL clean except for the resizeimage functions in maid-x11.c.

In the credits of maid-x11.c, the three people mentioned are Ben Harrison, Sebastien Desvignes, and Denis Eropkin. The first two are in the list as having given permission to GPL their code. The third is not, but is in the credits as writing the BMP format support. If the BMP functions are removed from the file, could the x11 tile code that I wrote be used in Angband? I have not yet found a good open source resizing function that does smoothing.

If you want to take a look at it, it is in my github repository at github.com/blubaron/z-angband.

Also there are settings.c/h to read a settings file that I wrote for ticket #636, but have not tried in windows yet, just x11.
Blue Baron is offline   Reply With Quote
Old February 5, 2013, 07:03   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
IIRC Denis Eropkin was one of the only ones (possibly the only one) never traced. Takkaria will have a better memory than I, but it sounds plausible that your code could be GPL-clean. Great work - a native X port will always be helpful to have.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old February 5, 2013, 12:37   #3
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by Blue Baron View Post
A long time ago, in an IRC dev meeting, I volunteered to re-add X11 tile support to Angband.

I've rewritten X11 tile support, adding PNG support, in my personal fork of Z+Angband. I think my changes are GPL clean except for the resizeimage functions in maid-x11.c.

In the credits of maid-x11.c, the three people mentioned are Ben Harrison, Sebastien Desvignes, and Denis Eropkin. The first two are in the list as having given permission to GPL their code. The third is not, but is in the credits as writing the BMP format support. If the BMP functions are removed from the file, could the x11 tile code that I wrote be used in Angband? I have not yet found a good open source resizing function that does smoothing.

If you want to take a look at it, it is in my github repository at github.com/blubaron/z-angband.

Also there are settings.c/h to read a settings file that I wrote for ticket #636, but have not tried in windows yet, just x11.
From the dual-licensing document I wrote a while back, "The X11 port's graphics support is non-free (by Torbjörn Lindgren), and in recent versions of Angband, the port featured clipboard copy support (by Kieron Dunbar) which was also non-free. With the removal of these features, the port is GPL-clean." [http://takkaria.org/angband-osi.html]

Now, I have no idea why Torbjörn Lindgren is mentioned there and isn't mentioned in the code, but I did extensive research so I can only assume this to be true. I will try and work out which code exactly is his.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old February 5, 2013, 12:56   #4
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,947
Donated: $40
takkaria is on a distinguished road
OK, so screw that, the person who actually wrote the resizing code is called Uwe Siems and it was nicked in January 2010. I can only assume there's one Uwe Siems using Linux and writing code and that person would appear to be here: https://launchpad.net/~usiems
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Old June 12, 2013, 01:29   #5
Blue Baron
Adept
 
Join Date: Apr 2011
Posts: 103
Blue Baron is on a distinguished road
Quote:
Originally Posted by takkaria View Post
OK, so screw that, the person who actually wrote the resizing code is called Uwe Siems and it was nicked in January 2010. I can only assume there's one Uwe Siems using Linux and writing code and that person would appear to be here: https://launchpad.net/~usiems
I looked at some old Angband source recently. The smooth resizing is in 3.0.9b, which on my drive has a file date of 5/14/2007.

Anyways, I removed the smooth resizing, so the resizing function is the same as in 2.8.3 and it seems to have been written by Sebastian Desvignes. It is in my x11-tiles branch.

BTW my x11-tiles branch is functional. It still needs work, especially in font handling and alphablending, but its functional.

The system menu is brought up by the escape key. Given the recent thread on more prompts, this may not be desirable.

There is a main loop in main.c that accepts n, o, and x for new game, open game, and exit, but I don't know how it will work with stats and tests. (Pressing o opens a textui file picker to select a save game file.)

I changed the settings file to use the same format as a windows ini file, using the code that I wrote for ticket 636. With the last commit, it should be read sound.cfg as well.
Blue Baron is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Need advice... X11 vs. SDL Therem Harth Development 25 October 25, 2011 03:35
Tile painters: request for a new tile takkaria Development 8 June 17, 2011 12:01
Angband under X11 Magnate Vanilla 3 December 13, 2009 21:56
Why no tile support in x11 port? bdo Vanilla 2 February 2, 2009 22:42
Sound on Linux with X11 is it available. tuppe666 Vanilla 10 September 13, 2007 16:42


All times are GMT +1. The time now is 14:11.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.