Go Back   Angband Forums > Angband > Development

Thread Tools Display Modes
Prev Previous Post   Next Post Next
Old August 4, 2011, 17:33   #1
Join Date: May 2009
Posts: 294
kaypy is on a distinguished road
[V3.3] Outdated graphics code

In the current system for feature graphics, we have 3 char/attr pairs:
A 'dark' pair
A 'torchlit' pair
and a 'lit' pair

OK, so far so good.

But there is also special casing code that changes anything white into yellow if it is torchlit, or into grey if it is dark. Which sort of defeats the purpose of having customizable tiles for each lighting level. Most of cave.c/grid_get_text should probably be removed.


The view_yellow_light option would need renaming to account for the torchlit tiles not necessarily being yellow anymore (actually they aren't necessarily yellow now- if you set the torchlit floor tile to be anything other than white or yellow)

We really could use torchlit floors being yellow by default here, unless we remove the view_yellow_light option as below.

If the view_yellow_light is not set, then anything torchlit will be displayed as lit instead. One could argue that this option is redundant, given the ability to explicitly set the torchlight grids to whatever you like, including exactly the same as regular lit grids. (I would say its probably premature to remove it yet, given the difficulty in editing feature graphics, but its on borrowed time)
kaypy is offline   Reply With Quote

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
No graphics? biff Vanilla 14 August 27, 2009 16:44
3.1 wall graphics Zappa Vanilla 3 June 28, 2009 00:49
[O] Graphics? hero Variants 4 September 8, 2007 23:40
problem with graphics mjtokarski Vanilla 11 July 8, 2007 00:40
Cannot initialize graphics katkt Vanilla 2 June 14, 2007 23:05

All times are GMT +1. The time now is 07:46.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.