Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old April 15, 2009, 00:13   #1
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,169
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Link warning

I've been getting this weird linker warning for a while in FA, and i'm wondering if anyone can enlighten me on it's cause and seriousness:

Code:
/usr/bin/ld: Warning: type of symbol `format' changed from 1 to 2 in z-form.o
My z-form.c is vary similar to V3.1.0, the only differences being inclusion of the xchar stuff from NPP (which I don't think can be related) and some use of C_MAKE and KILL instead of C_RNEW and FREE in vformat() (which I guess could be it).
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 15, 2009, 00:35   #2
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 6,591
Donated: $40
Pete Mack is on a distinguished road
How old is your copy of the linker? It looks there was a patch to ld sometime after early 2004.
Pete Mack is offline   Reply With Quote
Old April 15, 2009, 00:58   #3
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,169
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by Pete Mack View Post
How old is your copy of the linker? It looks there was a patch to ld sometime after early 2004.
ld -v says

Code:
GNU ld (GNU Binutils for Ubuntu) 2.18.93.20081009
Googling tells me that 2.19 is the latest version - maybe I should try and upgrade first...

...although apparently I have the current Ubuntu binutils package, and I usually don't go deeper than the package level with system modification.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 15, 2009, 03:59   #4
Pete Mack
Prophet
 
Join Date: Apr 2007
Location: Seattle, WA
Posts: 6,591
Donated: $40
Pete Mack is on a distinguished road
I guess the linker's not the problem. In that case, I have no idea.
Pete Mack is offline   Reply With Quote
Old April 15, 2009, 10:14   #5
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,169
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
It looks like the answer should be that 'format' has been used as a variable name before it's use as a function name in z-form.c; problem is I can't find any such thing. I'm wondering if somehow it's included from some library or include file or something. In any case, it looks more like an annoyance than a worry.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 15, 2009, 19:29   #6
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,060
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Nick View Post
It looks like the answer should be that 'format' has been used as a variable name before it's use as a function name in z-form.c; problem is I can't find any such thing. I'm wondering if somehow it's included from some library or include file or something.
'format' is one of the arguments taken by file_putf ... do you still use that?
Magnate is offline   Reply With Quote
Old April 15, 2009, 23:10   #7
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,169
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by Magnate View Post
'format' is one of the arguments taken by file_putf ... do you still use that?
It's still hanging around in z-file.c, but not used - and the argument it takes is fmt.

I'm annoyed and baffled about this, but I don't think it's actually causing any problems.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 15, 2009, 23:37   #8
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,060
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Nick View Post
It's still hanging around in z-file.c, but not used - and the argument it takes is fmt.
The argument is fmt in most places, but it's format in wiz-spoil.c, if you still have that ....
Magnate is offline   Reply With Quote
Old April 15, 2009, 23:49   #9
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,169
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by Magnate View Post
The argument is fmt in most places, but it's format in wiz-spoil.c, if you still have that ....
I think my wizard1.c is the equivalent, and it has no format.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old April 16, 2009, 03:50   #10
s0be
Apprentice
 
Join Date: Jan 2008
Posts: 96
s0be is on a distinguished road
Nick,

Care to share your source tree? I'll chase it down real quick like.
s0be is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Dead link buzzkill Oook! 1 February 10, 2009 09:26
@Takkaria! changes link. NeoWizard Vanilla 2 February 2, 2009 22:14
Help with diving (warning: long) bebo Vanilla 6 January 22, 2009 03:23


All times are GMT +1. The time now is 21:28.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.