Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Sil

Reply
 
Thread Tools Display Modes
Old October 31, 2013, 14:06   #1
debo
Veteran
 
debo's Avatar
 
Join Date: Oct 2011
Location: Toronto, Canada
Posts: 2,389
debo is on a distinguished road
Trumpet of Warning id by use?

I'm looking in use-obj.c and it seems to me that Trumpet of Warning is the only one which is impossible to id by use? I'm not sure if this was intentional or not, and I didn't examine too far so maybe I'm missing something.

It ignores the return value of fire_beam (all the other cases use it to determine whether the thing should be identified), and then it calls make_aggressive which returns nothing (so there doesn't seem to be any way from this fcn to even tell that it had an effect.)

I guess make_aggressive could be changed to return a value if any monsters switched behaviour, and *ident = TRUE on that?

This is obviously a minor thing, but if it's a bug I can just fix it lol
__________________
Glaurung, Father of the Dragons says, 'You cannot avoid the ballyhack.'
debo is offline   Reply With Quote
Old November 1, 2013, 00:48   #2
Patashu
Knight
 
Patashu's Avatar
 
Join Date: Jan 2008
Posts: 526
Patashu is on a distinguished road
Trumpet of warning should be ID'd by use if it hits a monster that is visible to you and it has a visible effect on its behavior.
__________________
My Chiptune music, made in Famitracker: http://soundcloud.com/patashu
Patashu is offline   Reply With Quote
Old November 1, 2013, 01:24   #3
taptap
Knight
 
Join Date: Jan 2013
Posts: 710
taptap is on a distinguished road
I wasn't aware of this, this is a selective wrath item? Cool.
taptap is offline   Reply With Quote
Old November 1, 2013, 04:06   #4
BlueFish
Swordsman
 
Join Date: Aug 2011
Posts: 414
BlueFish is on a distinguished road
The only trumpet I've ever used, and then only because I hadn't found a mattock, is a trumpet of blasting. The others seem very difficult to justify an inventory slot for.
BlueFish is offline   Reply With Quote
Old November 1, 2013, 04:15   #5
debo
Veteran
 
debo's Avatar
 
Join Date: Oct 2011
Location: Toronto, Canada
Posts: 2,389
debo is on a distinguished road
Terror is good as an escape if you have spare inv slots (e.g. when you find it early.) Especially if you get trapped in a corridor, as the beam can set a whole bunch of them fleeing.
__________________
Glaurung, Father of the Dragons says, 'You cannot avoid the ballyhack.'
debo is offline   Reply With Quote
Old November 1, 2013, 13:21   #6
half
Knight
 
half's Avatar
 
Join Date: Jan 2009
Posts: 904
half is on a distinguished road
Quote:
Originally Posted by BlueFish View Post
The only trumpet I've ever used, and then only because I hadn't found a mattock, is a trumpet of blasting. The others seem very difficult to justify an inventory slot for.
Why wouldn't you prefer a trumpet of blasting to a mattock? It seems generally much better to me. In fact, I think it is one of the best items in the game...
half is offline   Reply With Quote
Old November 1, 2013, 13:38   #7
debo
Veteran
 
debo's Avatar
 
Join Date: Oct 2011
Location: Toronto, Canada
Posts: 2,389
debo is on a distinguished road
Blasting is awesome, but I like to have a digger onhand as well in the endgame if I'm singing sharpness or something. I've been in situations before where I needed to dig in a hurry, and didn't have the 20 voice needed to use the trumpet. (I guess you can always blast down in an emergency, but that has its own set of problems.)

The other issue is your will score... if you want to dig with any kind of time constraint, the notion of failing your dig is sort of scary, especially if it's e.g. quartz that will reduce to rubble first.
__________________
Glaurung, Father of the Dragons says, 'You cannot avoid the ballyhack.'
debo is offline   Reply With Quote
Old November 1, 2013, 15:43   #8
half
Knight
 
half's Avatar
 
Join Date: Jan 2009
Posts: 904
half is on a distinguished road
Quote:
Originally Posted by debo View Post
Blasting is awesome, but I like to have a digger onhand as well in the endgame if I'm singing sharpness or something. I've been in situations before where I needed to dig in a hurry, and didn't have the 20 voice needed to use the trumpet. (I guess you can always blast down in an emergency, but that has its own set of problems.)

The other issue is your will score... if you want to dig with any kind of time constraint, the notion of failing your dig is sort of scary, especially if it's e.g. quartz that will reduce to rubble first.
Good points!
half is offline   Reply With Quote
Old November 2, 2013, 02:55   #9
BlueFish
Swordsman
 
Join Date: Aug 2011
Posts: 414
BlueFish is on a distinguished road
Quote:
Originally Posted by half View Post
Why wouldn't you prefer a trumpet of blasting to a mattock? It seems generally much better to me. In fact, I think it is one of the best items in the game...
I love 'em but mostly for Debo's reasons (lack of reliability due to will and song) I prefer mattocks. But I don't think it's obvious to take a plain mattock over a blasting horn. Mattock of Belegost on the other hand is a no-brainer for me as being better than the horn. I use belegost mattocks as an escape pretty regularly, when I have them. Especially, of course, when dealing with V.
BlueFish is offline   Reply With Quote
Old November 4, 2013, 23:38   #10
half
Knight
 
half's Avatar
 
Join Date: Jan 2009
Posts: 904
half is on a distinguished road
For the new version, trumpets of warning can now be ID'd by use (when they trigger a monster to shout or make a visible monster aggressive).

If there are any other non-ID-by-use items let me know. I want it to be that amulets of adornment are the only ones.
half is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Warning to those that play nightlies Timo Pietilš Vanilla 7 December 13, 2010 21:11
A warning of opinions to come! Susramanian Idle chatter 0 February 26, 2010 18:21
Down to a single compiler warning. PaulBlay Development 9 May 20, 2009 18:20
Link warning Nick Development 12 April 17, 2009 02:36
Help with diving (warning: long) bebo Vanilla 6 January 22, 2009 03:23


All times are GMT +1. The time now is 14:30.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.