Issues on current master

[Nick]

Originally Posted by t4nk

Nick, I got a crash from asan at obj-randart.c:2518:

while (strstr(art->name, "The One Ring") ||
	kf_has(kind->kind_flags, KF_QUEST_ART)) {
	(*aidx)++;
	art = &a_info[*aidx];
	art_level = art->level;
	if ((*aidx) >= z_info->a_max) {
		return;
	}
}

obj-init.c allocates z_info->a_max + 1 structs (line 2700), but note that it then increments a_max (line 2715). So accessing art->level when *aidx == a_max is illegal (perhaps that's the cause of Nomad's crash?)

Thank you, yes - I should be testing before incrementing.

Originally Posted by t4nk

(come to think of it, why does obj-init.c do that? and why does it start assigning from a_max, leaving zeroed out struct at the beginning?)

I don't actually remember. Each artifact in artifact.txt used to have an index, and they started at 1, and there was some code or other that relied on that fact, but I'm not at all sure it's necessary any more. I'll check at some point and change it if it's not needed, because it's a bit silly to do it for no reason.

[PowerWyrm]

Originally Posted by t4nk

come to think of it, why does obj-init.c do that? and why does it start assigning from a_max, leaving zeroed out struct at the beginning?

That's what the code does everywhere. The main reason is to put zero as index in the savefiles where there is nothing to save, while keeping a trivial loading routine: read index, assign struct = structs[index]. Otherwise, you would have to check the index, see if it's zero, assign null in that case, assign struct = structs[index-1] in other cases.

Note that in PWMAngband, I do the latter. It makes loading savefiles more complex, but simplifies all the rest (in particular, the init/parsing code).

[PowerWyrm]

Looking at master for implementing the latest stuff in PWMAngband. In commit a970eb7:

+
+	/* Uniques are doubly hard to affect */
+	if (rf_has(mon->race->flags, RF_UNIQUE)) {
+		resist_chance /= 2;
+	}

Well I think that makes uniques easier to affect no?

Best thing is to leave the double check in saving_throw(). Doing a *2 would make all level 50+ monsters completely immune to effects instead of giving them double resistance (double check at resist = 50 --> 75% vs single check at resist = 100 --> 100%).

if (rf_has(mon->race->flags, RF_UNIQUE) && (randint0(100) < resist_chance)) return true;

[PowerWyrm]

Minor issue: in commit e9458fa, many flags have been added to monster.txt, but some of them are already present in monster_base.txt (for example: NO_CONF on vortices).

[PowerWyrm]

Are traps still appearing only 25% of the time in vaults? I think the number of traps should be increased again, otherwise many vaults are very empty...

[t4nk]

Originally Posted by PowerWyrm

That's what the code does everywhere. The main reason is to put zero as index in the savefiles where there is nothing to save, while keeping a trivial loading routine: read index, assign struct = structs[index]. Otherwise, you would have to check the index, see if it's zero, assign null in that case, assign struct = structs[index-1] in other cases.

Ah, so that's how it was (angband now saves artefact names as strings instead).

[PowerWyrm]

Another minor issue: monsters break from "hold" effect when hit, but not from various other situations.

- hurt by earthquake
- summoned via "calling out"
- healed via "heal monster"

[takkaria]

Originally Posted by PowerWyrm

Another minor issue: monsters break from "hold" effect when hit, but not from various other situations.

- hurt by earthquake
- summoned via "calling out"
- healed via "heal monster"

I think I'm OK with this. I'll fix the other issues though, and also turn on saving throws for the unresistable effects soon.

[Wanderlust]

I had a problem compiling/installing the May 7 nightly.

I install locally with:

$ ./configure --prefix=$HOME --enable-sdl
$ make
$ make install

Running the program returns:

./angband: Cannot find required file:
/usr/local/share/angband/fonts/6x10x.fon

The same installation procedure works fine with earlier versions, such as the April 25 nightly, which I am running now with no problems.

[PowerWyrm]

Originally Posted by takkaria

I think I'm OK with this. I'll fix the other issues though, and also turn on saving throws for the unresistable effects soon.

Ok don't do that. For what I've seen, stuff like Slow and Confuse are still marginally useful because not really powerful, so it's ok to leave them without saving throw. The problem reported is vs Stun... and that's because there's a bug in the new implementation. Looking at mon-timed.h, the STUN_DAM_REDUCTION value is supposed to be "Percentage reduction in damage". But in mon-attack.c, the code is:

if (stunned) damage = (damage * STUN_DAM_REDUCTION) / 100;

The recent nerfing made that even worse, since this reduces monster damage to 10% of their normal damage while stunned...

Oh and it seems that the same problem applies for STUN_HIT_REDUCTION. In check_hit():

if (debuff) chance = (chance * debuff) / 100;

Fixing both of these will give some threat back to stunned monsters, and removing the saving throw for stunning will be also fine. Maybe bring back the 25% reduction instead of 10% too, because 10% won't do much, especially when damage is low due to rounding down.