Restructure update

[EpicMan]

I think this is due to VS not supporting newer C standards, specifically C99. This article has more info: http://stackoverflow.com/questions/1...-c-c-standards

The article mentions using the Intel compiler in place of Microsoft's, though I haven't tried that. You can also re-write the sections of code that aren't supported; I think if you change the struct declarations and change any array size definitions to constants you should be 95% done (or at least that was the case before the restructure).

[TJS]

Ah ok thanks for the information, I guess that Angband is not going to normally be compilable on Visual C++.

I might look into using another compiler and IDE, what do other people use when compiling the game?

[Nick]

Originally Posted by TJS

Hey up, I just tried to compile the latest code from git with Visual Studio Express 2010 and there are a whole bunch of syntax errors happening in get.h and get.c.

It does compile using MinGW but I can't debug it when it crashes.

Edit: there's also a syntax error in init.c as it doesn't like starting the member names with a dot:

static struct init_module arrays_module = {
.name = "arrays",
.init = init_arrays,
.cleanup = cleanup_arrays
};

The get.* issue is easily solved - they're not used, delete them.

The other error may well be a VS problem - I thought that MS had included enough of the C99 standard now, but apparently not.

I believe I have managed to debug in windows using msys, MinGW and gdb, but I may be misremembering.

[AnonymousHero]

Originally Posted by Nick

The get.* issue is easily solved - they're not used, delete them.

The other error may well be a VS problem - I thought that MS had included enough of the C99 standard now, but apparently not.

I believe I have managed to debug in windows using msys, MinGW and gdb, but I may be misremembering.

Nope, no C99 for you in VS. (Not even stdint.h as I recall!)

They do support(-ish) recent versions of C++, but that's not really relevant here. Of course C++ initializer syntax is incompatible with C99 anyway, so...

[TJS]

Originally Posted by Nick

The get.* issue is easily solved - they're not used, delete them.

The other error may well be a VS problem - I thought that MS had included enough of the C99 standard now, but apparently not.

I believe I have managed to debug in windows using msys, MinGW and gdb, but I may be misremembering.

Do you think it might be made VS compatible sometime?

[Nick]

Originally Posted by TJS

Do you think it might be made VS compatible sometime?

Well, you never know - maybe Microsoft will implement support for modern C one day

By the way, have you checked out this thread? I assume that it is not much help, but there might be something in there of use to you.

[TJS]

Originally Posted by Nick

Well, you never know - maybe Microsoft will implement support for modern C one day

Seems completely mad that Microsoft won't implement the latest standards.

I guess that it is a balance though between wanting to use the latest shiny code standards and reducing compatibility for people who might want to help with the game

Are the new code standards that vital to use despite reducing who can compile the game? (Genuine question I'm not trying to be argumentative or anything, I'm not really up to date on these things). Angband used to compile on VS no problem in the past.

By the way, have you checked out this thread? I assume that it is not much help, but there might be something in there of use to you.

I spend a few hours trying to get it to compile on various systems. I got MinGW working, but I couldn't figure out any way of debugging it or a IDE that went with it. I couldn't figure out Eclipse at all. I suck at this sort of thing

[Nick]

Originally Posted by TJS

I guess that it is a balance though between wanting to use the latest shiny code standards and reducing compatibility for people who might want to help with the game

Are the new code standards that vital to use despite reducing who can compile the game? (Genuine question I'm not trying to be argumentative or anything, I'm not really up to date on these things). Angband used to compile on VS no problem in the past.

I tend to favour utility over shininess.

I think

static struct init_module arrays_module = {
"arrays",
init_arrays,
cleanup_arrays
};

should work (and the same for any other similar construction). Let me know if it does, and what other problems you run into, and we'll see what we can do

[debo]

Something with a '99' in its name should probably have a good patina by now, anyways

[Quendus]

TJS did say they were using VS express 2010 - MS might have improved C99 support in VS 2012 and 2013 (which also have free express versions).