Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Variants

Reply
 
Thread Tools Display Modes
Old July 5, 2021, 07:02   #371
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,163
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by MITZE View Post
As far as I can tell, the crash that deposits you on the level you were trying to enter seems to have something to do with player ghosts; as far as I've noticed, every time it's happened there's been a player ghost when I've reloaded the game. In case this is valuable information for debugging, I've been scumming for these crashes going between Amon Rudh 15 and West Beleriand 16; the player ghosts I've confirmed involved when the crash happens are 'BEEFCAKE', 'Dex', 'Judias', 'Klassik', 'Rythil', and 'WildKhaine'.

As for the crash that deposits you on the level you were trying to leave, it's only happened to me once or twice during my bugtesting time, and it hasn't been replicatable; I've been making a habit of saving before attempting to make a transition during this, and when this crash happened it didn't occur when I tried the transition a second time--not sure if saving screwed with the RNG or what.

EDIT: Confirmed the crash that deposits you on the level you were trying is not replicatable; spammed wilderness transitions without saving for a while and found it again, but it still didn't occur when trying the transition a second time.
This is all really useful information. I suspect (well, hope) finding the first issue won't be too hard now, as it's almost certainly related to ghost generation, and apparently after level generation. The second one is happening during level generation, so may be harder to find.

Did you get any instances of the game hanging?
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 5, 2021, 08:35   #372
MITZE
Adept
 
Join Date: Jan 2017
Location: Pennsylvania, United States
Posts: 214
MITZE is on a distinguished road
Quote:
Originally Posted by Nick View Post
Did you get any instances of the game hanging?
No lockups for me, though there were a few instances of the transition taking a non-negligable amount of time to happen; this may or may not be a webserver consequence rather than a game issue though.

(Incidentally, I had been wondering if Rolanako's lockup had just been him coincidentally running into connection issues at the same time--no way to tell now, though.)
__________________
Everything you need to know about my roguelike playstyle:

I took nearly two years to win with a single character in PosChengband.

Last edited by MITZE; July 5, 2021 at 08:35. Reason: Fixed formatting.
MITZE is offline   Reply With Quote
Old July 5, 2021, 13:59   #373
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,163
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
OK, I've found a memory error in wilderness and updated - see if that makes a difference.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 5, 2021, 14:42   #374
Cuboideb
Adept
 
Join Date: May 2020
Location: Argentina
Posts: 181
Cuboideb is on a distinguished road
Quote:
Originally Posted by Cuboideb View Post
In ui-death.c, line 353. file_close should be outside the infinite loop. If the user answers N that line could never be executed. Perhaps the loop should be closed at line 337.
I tried this fix. Bone files are properly generated now in android.
Cuboideb is offline   Reply With Quote
Old July 5, 2021, 21:47   #375
MITZE
Adept
 
Join Date: Jan 2017
Location: Pennsylvania, United States
Posts: 214
MITZE is on a distinguished road
Quote:
Originally Posted by Nick View Post
OK, I've found a memory error in wilderness and updated - see if that makes a difference.
Both crashes still happen.
__________________
Everything you need to know about my roguelike playstyle:

I took nearly two years to win with a single character in PosChengband.

Last edited by MITZE; July 5, 2021 at 21:48. Reason: Fixed formatting.
MITZE is offline   Reply With Quote
Old July 5, 2021, 23:30   #376
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,163
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by Cuboideb View Post
I tried this fix. Bone files are properly generated now in android.
Thanks, I've done an overhaul of that code which includes your fix, and I think it now works properly.

Crashes I will get to another time.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 8, 2021, 06:11   #377
MITZE
Adept
 
Join Date: Jan 2017
Location: Pennsylvania, United States
Posts: 214
MITZE is on a distinguished road
Exclamation Bug Spotted?

Perhaps a stupid question (because I really don't know newFA code), but should line 719 in mon-make.c be false rather than true?

As far as I understand it, the entire function it's in is returning true or false based on whether it's successfully created a player ghost, but that particular line is part of a check to determine whether the monster is supposed to be a player ghost at all?
__________________
Everything you need to know about my roguelike playstyle:

I took nearly two years to win with a single character in PosChengband.

Last edited by MITZE; July 8, 2021 at 06:17. Reason: Fixed formatting.
MITZE is offline   Reply With Quote
Old July 8, 2021, 06:19   #378
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,163
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by MITZE View Post
Perhaps a stupid question (because I really don't know newFA code), but should line 719 in mon-make.c be false rather than true?

As far as I understand it, the entire function it's in is returning true or false based on whether it's successfully created a player ghost, but that particular line is part of a check to determine whether the monster is eligible to be a player ghost at all?
I think you're right, and I'll change it, but in practice it shouldn't make a difference because that check is also done before the prepare_ghost() function is called.
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Old July 12, 2021, 15:15   #379
MITZE
Adept
 
Join Date: Jan 2017
Location: Pennsylvania, United States
Posts: 214
MITZE is on a distinguished road
Quote:
Originally Posted by Nick View Post
[08:50] Nick: OK, let's hope it's just ghosts then
[08:52] Nick: Start of level with ghost, reloading with ghost, encountering ghost, or something else?
Continuing the webserver conversation, but it's still the same problem: there are relatively frequent crashes when you go to transition to a new level (only in the wilderness? I should probably check that.).

After the crash happens, reloading the game will put you on the level you were trying to transition to, and as far as I've noticed there's always a player ghost on said level.
__________________
Everything you need to know about my roguelike playstyle:

I took nearly two years to win with a single character in PosChengband.

Last edited by MITZE; July 12, 2021 at 15:15. Reason: Fixed formatting.
MITZE is offline   Reply With Quote
Old July 12, 2021, 23:02   #380
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 56
Posts: 9,163
Donated: $60
Nick will become famous soon enoughNick will become famous soon enough
Quote:
Originally Posted by MITZE View Post
Continuing the webserver conversation, but it's still the same problem: there are relatively frequent crashes when you go to transition to a new level (only in the wilderness? I should probably check that.).

After the crash happens, reloading the game will put you on the level you were trying to transition to, and as far as I've noticed there's always a player ghost on said level.
OK, I'll do some testing offline too, and if it keeps not happening we'll blame Gwarl (or probably the interaction of player ghosts with multiuser setup, actually).
__________________
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
Nick is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
FAangband 1.4 Nick Variants 147 November 30, 2015 10:18
Angband 4.0beta status Nick Vanilla 577 June 28, 2015 01:16
Woohoo! My second 4.0beta win! Ingwe Ingweron AAR 1 May 13, 2015 22:46
FAangband 1.1 Nick Variants 483 July 19, 2011 14:04
3.1.0beta monster behavior and a few other things tigen Vanilla 3 January 17, 2009 08:30


All times are GMT +1. The time now is 13:49.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.