npp floor interaction bug

[Old Coach]

Is anyone else having trouble interacting with items on the floor? When my inventory is mostly empty, I rarely have problems. However, once I start getting above around 12 items in my inventory, I start having the following problem:

When I try to Identify an item on the floor, the game crashes.
When I try to pick up an item with the g command, the game crashes. I can avoid this problem if I pick up items automatically or with the 5 command, and then identify them from my inventory. This crash happens irregardless of what graphics I am using, and also whether or not I am enabling the drop down menus (interface options).

It could just be an artifact of my old computer.

Also, giant white rats come up brown with the new tile set

[ghengiz]

Originally Posted by Old Coach

Is anyone else having trouble interacting with items on the floor? When my inventory is mostly empty, I rarely have problems. However, once I start getting above around 12 items in my inventory, I start having the following problem:

When I try to Identify an item on the floor, the game crashes.
When I try to pick up an item with the g command, the game crashes. I can avoid this problem if I pick up items automatically or with the 5 command, and then identify them from my inventory. This crash happens irregardless of what graphics I am using, and also whether or not I am enabling the drop down menus (interface options).

It could just be an artifact of my old computer.

Also, giant white rats come up brown with the new tile set

I'm not sure if this qualify as a crash, but something along this lines just happened to me too. Details follow.

port:gcu
options: autopickup off, prompt beforeusing floor items = yes, prompt before picking things up = yes.
inventory slots a-l not empty; the moment I picked up the 'm'-slot object (iron spikes), the screen bocome black, only the @ and the cursor are visible, but the game is not hung, because it responds to the movement, inventory, equipment, options, run commands and probably others.
refreshing the screen doesn't help

I cannot confirm the identify issue because I have no id scrolls at the moment.

edit:
saving and reloading fixes the display

[nppangband]

Thanks, I will try to re-create this. Just curious what version you downloaded, and at what time it was downloaded. I have been uploading fixes to github, and I uploaded one this morning regarding item selection that, now that I think about it, could possibly result in crashes in the situation you describe below (picking up items off the floor, identifying items). If by chance you come across this bug shortly after saving an item, please send me the savefile.

@old coach - I think I know what is happening in your situation. I should be able to put out a fix when I get home from work.

The reason the game is crashing is because in certain circumstances the game returns the slot of an item on the floor as negative, and it has to be changed to a positive before accessing the object information in the object table. I recently tied the floor pickup menu to the new ui menu, and I think I know where the signs might be mixed up in the code that handles object pickup.

[buzzkill]

Originally Posted by Old Coach

Also, giant white rats come up brown with the new tile set

Fixed on my end. Thanks.

[nppangband]

Originally Posted by ghengiz

I'm not sure if this qualify as a crash, but something along this lines just happened to me too. Details follow.

port:gcu
options: autopickup off, prompt beforeusing floor items = yes, prompt before picking things up = yes.
inventory slots a-l not empty; the moment I picked up the 'm'-slot object (iron spikes), the screen bocome black, only the @ and the cursor are visible, but the game is not hung, because it responds to the movement, inventory, equipment, options, run commands and probably others.
refreshing the screen doesn't help

I cannot confirm the identify issue because I have no id scrolls at the moment.

edit:
saving and reloading fixes the display

This one should be fixed too. Inthe pickup menu There was a leftover screen_load without a corresponding screen save, so it loaded a blank screen.