Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old April 1, 2011, 13:19   #1
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,954
PowerWyrm is on a distinguished road
Macros are... gone???

As a variant maintainer who just implemented some features from V3.2 in his variant, I found a bug when running the SDL client: the new pref parser cannot parse pref-sdl.prf correctly because of the "T:\::\:" line. This line is misinterpreted as "T \ \" (using ":" as token for parsing) instead of "T : :", and then translated into n1 = NULL, n2 = NULL by the parse_prefs_t() hook. The result is that when parsing the next line, parser_freeold() crashes with a NULL pointer exception when trying to free some memory related to n1 and n2.

Since I wanted to fix this, I tried to look at the latest source code in the repository... and found that parse_prefs_t() didn't exist anymore. In fact, pref-sdl.prf doesn't exist anymore, as well as anything related to Macro Trigger configuration.

Investigating further, I found a committed changeset... that simply removed the entire macro system!!!

Will this system be replaced by something else? I have a BIG problem here... My variant is real-time based, not turn-based. It's impossible for a player to type 3-4 keys (command, item choice, direction, target...) while struggling to keep the character alive in real-time. In Vanilla Angband, the macro system is kinda pointless... but in my variant it's primordial to be able to perform an action with one key.

There's some cool stuff here: http://trac.rephial.org/wiki/InputRework. I hope this will be implemented...
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old April 1, 2011, 13:53   #2
takkaria
Veteran
 
takkaria's Avatar
 
Join Date: Apr 2007
Posts: 1,950
Donated: $40
takkaria is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
Investigating further, I found a committed changeset... that simply removed the entire macro system!!!

Will this system be replaced by something else? I have a BIG problem here... My variant is real-time based, not turn-based. It's impossible for a player to type 3-4 keys (command, item choice, direction, target...) while struggling to keep the character alive in real-time. In Vanilla Angband, the macro system is kinda pointless... but in my variant it's primordial to be able to perform an action with one key.

There's some cool stuff here: http://trac.rephial.org/wiki/InputRework. I hope this will be implemented...
Keymaps are better now, so macros aren't necessary. You saw a commit that removed macros read a bit closer and you'll see it did a lot of other work, amounting to rewrite of the input system in a way that makes keypress handling a lot cleaner. As part of that, keymaps should do everything you wanted macros to do.
__________________
takkaria whispers something about options. -more-
takkaria is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
What are your macros? Raxmei Vanilla 4 March 22, 2011 20:00
Unangband - No Macros? Bostock Variants 5 September 23, 2010 19:54
Macros help ZenDragon Vanilla 3 June 10, 2010 01:28
[SA] Macros in SAngband? Poop Loops Variants 1 June 13, 2008 18:36
On macros... Wisp Vanilla 5 February 26, 2008 21:37


All times are GMT +1. The time now is 03:39.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2023, vBulletin Solutions Inc.