Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old October 2, 2011, 11:45   #1
fph
Knight
 
Join Date: Apr 2009
Location: Berlin / Italy
Posts: 767
fph is on a distinguished road
Object stacking "bug"

I am playing build ga914ed2, with pack size reduced to 25.

I picked up 3 !CLW while I had 23 other in my inventory. Now they show up separately as 23 !CLW in one stack and 3 in another. OTOH, when I do the same with the arrows in the quiver, then the first stack gets maxed up to 25 and then the remaining arrows "overflow" to the next stack. This seems inconsistent, and the proper behaviour should be the one implemented in the quiver (25+1 rather than 23+3).

btw, I like pack_size=25 for now, even though I haven't been shooting much with this character.
__________________
Dive fast, die young, leave a high-CHA corpse.
--
You read a scroll labeled 'lol gtfo' of Teleport Level.
fph is offline   Reply With Quote
Old October 2, 2011, 12:03   #2
fph
Knight
 
Join Date: Apr 2009
Location: Berlin / Italy
Posts: 767
fph is on a distinguished road
And another related oddity: when I have 23 !CLW in one pack and there's 3 on the floor and my inventory is full, I cannot pick only two of them up. Some inventory juggling is needed to obtain the proper result.
__________________
Dive fast, die young, leave a high-CHA corpse.
--
You read a scroll labeled 'lol gtfo' of Teleport Level.
fph is offline   Reply With Quote
Old October 2, 2011, 16:22   #3
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 39
Posts: 1,516
d_m is on a distinguished road
Quote:
Originally Posted by fph View Post
And another related oddity: when I have 23 !CLW in one pack and there's 3 on the floor and my inventory is full, I cannot pick only two of them up. Some inventory juggling is needed to obtain the proper result.
Good call.

I wrote some special quiver-spillover code that will probably need to be generalized for this to work.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old October 3, 2011, 12:05   #4
Nomad
Knight
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 958
Nomad is on a distinguished road
Currently playing g74b42d1, and discovered a some weirdness with the new stack size limits when buying in the town. I bought 30 enchanted arrows from a shop, and they entered my inventory as a stack of 30. I equipped them to the quiver, and on the 'e' screen they were shown as a stack of 30 in one slot, although the 'i' screen had the correct behaviour, showing two "in Quiver" lines with 25 and 5.

I was able to drop the full 30 stack and pick it up again without it splitting, though when I dropped 10 of the arrows and then picked those up, the arrows didn't recombine but stayed split into two stacks of 20/10.

Possibly the simplest answer to this is just that shops shouldn't be selling ammo in stacks of >25 in the first place? I see that the standard stocks of average ammo have been reduced from 99 to 25, but it looks like the random stacks of enchanted ammo sometimes sold may have escaped via a loophole.

Iron spikes are also currently stocked in stacks higher than 25. Just got some further interesting behaviour checking the problem with the arrows could be reproduced: the shop had 60 spikes, I bought 30 of them (and did indeed get them as a stack of 30). Then I sold them back, and the shop's remaining stock suddenly went down to 25. (The other 5 and the 30 I sold back all disappeared rather than showing up as another stack in the shop inventory.) So that maximum must be set somewhere, but something's gone a little bit wonky.
Nomad is offline   Reply With Quote
Old October 3, 2011, 18:50   #5
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 39
Posts: 1,516
d_m is on a distinguished road
Was this a new game, or a saved game?

The game should no longer be generating stacks of more than 25 for sale, but old stacks might still be hanging around.

If you started a new game with the 25 limit and still saw a stack of 30 then this is a bug.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old October 3, 2011, 19:05   #6
Nomad
Knight
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 958
Nomad is on a distinguished road
Quote:
Originally Posted by d_m View Post
Was this a new game, or a saved game?

The game should no longer be generating stacks of more than 25 for sale, but old stacks might still be hanging around.

If you started a new game with the 25 limit and still saw a stack of 30 then this is a bug.
It was a brand new game started from scratch in g74b42d1. I've played three or four games in that version now, and it seems like everything appears in stacks of 25 or less except for iron spikes and sometimes ammo at the weaponsmith.
Nomad is offline   Reply With Quote
Old October 3, 2011, 19:20   #7
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 39
Posts: 1,516
d_m is on a distinguished road
Quote:
Originally Posted by Nomad View Post
It was a brand new game started from scratch in g74b42d1. I've played three or four games in that version now, and it seems like everything appears in stacks of 25 or less except for iron spikes and sometimes ammo at the weaponsmith.
Huh, weird. Thanks for the report!

I will try to replicate and fix this. I'm assuming it's legit, but if anyone else has seen this I'd love confirmation that it's still an issue.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old October 15, 2011, 20:01   #8
dos350
Knight
 
dos350's Avatar
 
Join Date: Sep 2010
Location: nimbin, australia
Posts: 541
dos350 is on a distinguished road
these new stack limits suck so much why do this 2 angband ?~ please no rage
__________________
~eek

Reality hits you -more-

S+++++++++++++++++++
dos350 is offline   Reply With Quote
Old October 15, 2011, 21:20   #9
bulian
Adept
 
Join Date: Sep 2010
Posts: 162
bulian is on a distinguished road
I'll trust the older players this change is good to limit power of ranged attacks, but I'm concerned about limited capacity for consumables in ironman games. Has anyone played ironman with the reduced stack sizes?

Being able to carry only 25 (or 40) CCW might be risky at best, and devoting a second (or third) slot might be challenging given the inventory constraints. Apologies if this has already been discussed.

The comp 107 winners (ironman warrior) had 0 and 31 CCW potions in inventory, though Ewan said he stashed a bunch. My winner (http://angband.oook.cz/ladder-show.php?id=11781) had 22. Likely the numbers going into the final fight were all higher than 25.
bulian is offline   Reply With Quote
Old October 15, 2011, 23:45   #10
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by bulian View Post
I'll trust the older players this change is good to limit power of ranged attacks, but I'm concerned about limited capacity for consumables in ironman games. Has anyone played ironman with the reduced stack sizes?

Being able to carry only 25 (or 40) CCW might be risky at best, and devoting a second (or third) slot might be challenging given the inventory constraints. Apologies if this has already been discussed.

The comp 107 winners (ironman warrior) had 0 and 31 CCW potions in inventory, though Ewan said he stashed a bunch. My winner (http://angband.oook.cz/ladder-show.php?id=11781) had 22. Likely the numbers going into the final fight were all higher than 25.
There's nothing stopping you carrying more than one stack ...
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Bug: "Find Traps, Doors & Stairs" doesn't work on chests Raggy Vanilla 26 June 29, 2011 13:28
"Great" drops replaced by "good" drops in vaults: bug or feature? PowerWyrm Vanilla 14 February 27, 2010 15:54
possible bug with "player turns" in dump? PowerDiver Development 1 December 15, 2009 08:03
"repeat" Command just little bit "smarter" ClaytonAguiar Vanilla 8 June 17, 2009 15:01
Object Stacking bug 309 APWhite Vanilla 3 October 23, 2007 10:04


All times are GMT +1. The time now is 01:03.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.