Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old May 31, 2009, 22:29   #1
bebo
Adept
 
bebo's Avatar
 
Join Date: Jan 2009
Location: Milan, Italy
Posts: 213
bebo is on a distinguished road
bug: monster list r1418

First of all I would like to say that the new improvements to the monster list are great (thanks magnate), being able to know which monsters are asleep and if they have los is really useful.

Just one suggestion, it might improve readability if a blank line would be put between the two groups.

Anyways, it seems like the (asleep) descriptor is a bit broken - namely i hit a monster that was asleep, it woke up and started running away but still appeared as sleeping in the monster list. Savefile attached.
Attached Files
File Type: zip savefile.zip (14.9 KB, 217 views)
bebo is offline   Reply With Quote
Old June 1, 2009, 08:08   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by bebo View Post
First of all I would like to say that the new improvements to the monster list are great (thanks magnate), being able to know which monsters are asleep and if they have los is really useful.

Just one suggestion, it might improve readability if a blank line would be put between the two groups.
I thought about that, but I figured space was at a premium (my monster list window is tiny). Especially as most of the time (i.e. without ESP or casting Detect Something), the last line is "You are aware of 0 other monsters."
Quote:
Anyways, it seems like the (asleep) descriptor is a bit broken - namely i hit a monster that was asleep, it woke up and started running away but still appeared as sleeping in the monster list. Savefile attached.
Ah, thank you. I suspect this is to do with how/when the list is refreshed, rather than with the new list code itself (though it is always possible that m_ptr->csleep is not being updated). I'll look into it tonight.
Magnate is offline   Reply With Quote
Old June 1, 2009, 09:59   #3
bebo
Adept
 
bebo's Avatar
 
Join Date: Jan 2009
Location: Milan, Italy
Posts: 213
bebo is on a distinguished road
Quote:
Originally Posted by Magnate View Post
I thought about that, but I figured space was at a premium (my monster list window is tiny). Especially as most of the time (i.e. without ESP or casting Detect Something), the last line is "You are aware of 0 other monsters."
You're right - maybe like suggested in the other thread simply not displaying the line "You are aware of 0 other monsters." (of course only when it's 0) is the most elegant solution?
bebo is offline   Reply With Quote
Old June 1, 2009, 18:17   #4
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by bebo View Post
You're right - maybe like suggested in the other thread simply not displaying the line "You are aware of 0 other monsters." (of course only when it's 0) is the most elegant solution?
Yes, I think I agree with that. Fixed in r1425.

Last edited by Magnate; June 1, 2009 at 20:04.
Magnate is offline   Reply With Quote
Old June 13, 2009, 14:38   #5
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Magnate View Post
I suspect this is to do with how/when the list is refreshed, rather than with the new list code itself (though it is always possible that m_ptr->csleep is not being updated). I'll look into it tonight.
Fixed in r1440.
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Feature request: scramble the monster list when hallucinating! jv123 Vanilla 2 May 18, 2009 02:30
Monster knowledge menu - bug JamesDoyle Vanilla 1 March 1, 2009 10:10
3.1 v bug (squelch list) Zikke Vanilla 1 January 27, 2009 20:12
monster list info DaviddesJ Vanilla 1 March 31, 2008 03:10
The Visible monster list, modifications. Irashtar Vanilla 4 October 27, 2007 01:40


All times are GMT +1. The time now is 15:14.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.