Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old June 9, 2009, 17:32   #1
Zikke
Veteran
 
Join Date: Jun 2008
Location: Los Angeles
Posts: 1,020
Zikke is on a distinguished road
Dropping squelch items

Is there a reason why when I pseudo-ID an object as "bad" then my character will drop it automatically right away, but when I use a wand or something of Heal Monster and it marks it as {squelch} then it doesn't drop it right away? It waits until the next time I pick something up.

Is there a way to make it consistent and drop any squelched item instantly?
__________________
A(3.1.0b) CWS "Fyren_V" NEW L:50 DL:127 A++ R+++ Sp+ w:The Great Axe of Eonwe
A/FA W H- D c-- !f PV+++ s? d P++ M+
C- S+ I- !So B ac++ GHB? SQ? !RQ V F:
Zikke is offline   Reply With Quote
Old June 9, 2009, 18:36   #2
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,588
PowerDiver is on a distinguished road
Quote:
Originally Posted by Zikke View Post
Is there a reason why when I pseudo-ID an object as "bad" then my character will drop it automatically right away, but when I use a wand or something of Heal Monster and it marks it as {squelch} then it doesn't drop it right away? It waits until the next time I pick something up.

Is there a way to make it consistent and drop any squelched item instantly?
The problem is sloppy code. Currently, in any place in the code where you do an action leading to learning something needs to be squelched, the programmer adds an instruction to drop squelched objects. Somebody overlooked your problem. This stuff should have been done instead in the code where things are noticed about objects.

In other words, it's a bug. I'll get a fix to Takkaria eventually.
PowerDiver is offline   Reply With Quote
Old June 9, 2009, 18:42   #3
Zikke
Veteran
 
Join Date: Jun 2008
Location: Los Angeles
Posts: 1,020
Zikke is on a distinguished road
Okay thanks low priority
__________________
A(3.1.0b) CWS "Fyren_V" NEW L:50 DL:127 A++ R+++ Sp+ w:The Great Axe of Eonwe
A/FA W H- D c-- !f PV+++ s? d P++ M+
C- S+ I- !So B ac++ GHB? SQ? !RQ V F:
Zikke is offline   Reply With Quote
Old June 9, 2009, 19:31   #4
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 4,992
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by Zikke View Post
Okay thanks low priority
It's a single line:

p_ptr->notice |= PN_SQUELCH;

I'll see if I can work out where to put it - presumably after the learning bit of aiming/zapping/using.

CC
Magnate is offline   Reply With Quote
Old June 9, 2009, 19:36   #5
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,588
PowerDiver is on a distinguished road
Quote:
Originally Posted by Magnate View Post
It's a single line:

p_ptr->notice |= PN_SQUELCH;

I'll see if I can work out where to put it - presumably after the learning bit of aiming/zapping/using.

CC
If you want to do it now, put it into object_aware and object_known.
PowerDiver is offline   Reply With Quote
Old June 9, 2009, 19:37   #6
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 4,992
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by PowerDiver View Post
If you want to do it now, put it into object_aware and object_known.
That won't break how it's done at the moment (which is in the higher-level functions that call those)?

Thinks: I guess not, since there's no harm in it being set twice. Leaves the code a bit ugly though - I'd want to go through and remove the extraneous invocations.
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
What does Squelch do? Wraitheist Vanilla 7 September 6, 2009 19:55
Mixed-blessing items takkaria Vanilla 39 June 17, 2008 03:50
Selling cursed items z118 Vanilla 5 January 29, 2008 17:23
Prevent selling items ish Vanilla 1 August 29, 2007 11:12
What about new items? Mondkalb Vanilla 16 May 30, 2007 12:25


All times are GMT +1. The time now is 18:54.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.