Dropping squelch items

[Zikke]

Is there a reason why when I pseudo-ID an object as "bad" then my character will drop it automatically right away, but when I use a wand or something of Heal Monster and it marks it as {squelch} then it doesn't drop it right away? It waits until the next time I pick something up.

Is there a way to make it consistent and drop any squelched item instantly?

[PowerDiver]

Originally Posted by Zikke

Is there a reason why when I pseudo-ID an object as "bad" then my character will drop it automatically right away, but when I use a wand or something of Heal Monster and it marks it as {squelch} then it doesn't drop it right away? It waits until the next time I pick something up.

Is there a way to make it consistent and drop any squelched item instantly?

The problem is sloppy code. Currently, in any place in the code where you do an action leading to learning something needs to be squelched, the programmer adds an instruction to drop squelched objects. Somebody overlooked your problem. This stuff should have been done instead in the code where things are noticed about objects.

In other words, it's a bug. I'll get a fix to Takkaria eventually.

[Zikke]

Okay thanks low priority

[Magnate]

Originally Posted by Zikke

Okay thanks low priority

It's a single line:

p_ptr->notice |= PN_SQUELCH;

I'll see if I can work out where to put it - presumably after the learning bit of aiming/zapping/using.

CC

[PowerDiver]

Originally Posted by Magnate

It's a single line:

p_ptr->notice |= PN_SQUELCH;

I'll see if I can work out where to put it - presumably after the learning bit of aiming/zapping/using.

CC

If you want to do it now, put it into object_aware and object_known.

[Magnate]

Originally Posted by PowerDiver

If you want to do it now, put it into object_aware and object_known.

That won't break how it's done at the moment (which is in the higher-level functions that call those)?

Thinks: I guess not, since there's no harm in it being set twice. Leaves the code a bit ugly though - I'd want to go through and remove the extraneous invocations.