Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old October 24, 2009, 22:51   #1
miyazaki
Adept
 
miyazaki's Avatar
 
Join Date: Jan 2009
Location: BC, Canada
Age: 42
Posts: 227
miyazaki is on a distinguished road
Crash in V 3.1.1 v1626

V1626 has been really stable for me so far but crashed yesterday. I quaffed a potion of dragon breath right off the floor and the system crashed. I can't remember if it was a single potion or not but the last message said that the potion shattered. I think I breathed frost and mayhave shattered the potion that I just drank? Anyone else experienced this?
miyazaki is offline   Reply With Quote
Old October 25, 2009, 00:05   #2
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
That seems like a unique problem. I haven't seen it, but it makes sense. You use a consumable that destroys itself, which results in the object being deleted twice as the code is currently written, obviously a bad thing. The closest thing I can think of is the rod of elec balls destroying itself, but no crash since the rod isn't a consumable. A scroll of destruction is no problem since the square you are on is not affected.
PowerDiver is offline   Reply With Quote
Old October 28, 2009, 06:26   #3
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 38
Posts: 1,516
d_m is on a distinguished road
Fixed in r1683 (see http://trac.rephial.org/ticket/975).

Also, it seems that despite his vacation Takkaria still spends enough time monitoring Angband to open tickets!
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old October 28, 2009, 17:06   #4
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
Quote:
Originally Posted by d_m View Post
Was this done the right way, by deleting the object when used but before the effect happens, and saving a pointer to the kind_info and later modifying kind learning when anything is learned? That's tricky to do when some consumables can be aborted in the functions that produce effects. The optional selection hook (affected item, obj, letter, or dir etc) might have to be separated from the effect code, or else you need to be able to undelete.

Or did you just add IGNORE_COLD to that particular potion?

I suppose the speed of the fix answers my question.
PowerDiver is offline   Reply With Quote
Old October 28, 2009, 19:14   #5
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 38
Posts: 1,516
d_m is on a distinguished road
Quote:
Originally Posted by PowerDiver View Post
Was this done the right way, by deleting the object when used but before the effect happens, and saving a pointer to the kind_info and later modifying kind learning when anything is learned? That's tricky to do when some consumables can be aborted in the functions that produce effects. The optional selection hook (affected item, obj, letter, or dir etc) might have to be separated from the effect code, or else you need to be able to undelete.

Or did you just add IGNORE_COLD to that particular potion?

I suppose the speed of the fix answers my question.
Neither of those actually. I just had the "normal" deletion check to see if effect_do() actually deleted the item already.

It's not as much of a hack as IGNORE_COLD but more so than refactoring a bunch of effect_do() and/or cmd-obj.c

EDIT: And of course you can always check the cvs diff if you're curious...
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Morgoth crash Zikke Vanilla 9 July 25, 2009 23:47
[FA] Crash Bug Zikke Variants 8 February 19, 2009 05:20
3.1.1 strange crash bebo Vanilla 1 February 9, 2009 00:49
Entro crash Zikke Variants 2 February 2, 2009 21:08
Shopping crash FA, O maybe others buzzkill Variants 5 November 18, 2008 00:45


All times are GMT +1. The time now is 14:35.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.