[Announce] NPPAngband 0.5.1 WIP

[nppangband]

Originally Posted by Tatami

I just rolled a high elf ranger and the character description is missing a few spaces between the different aspects of the char description. I know I know, stop the presses the game doesn't function..

That was a tough one, but I think I came up with something that will hopefully work. Thanks.

[Tatami]

Originally Posted by nppangband

That was a tough one, but I think I came up with something that will hopefully work. Thanks.

You guys are miracle workers.

Seriously: Will give NPP another hard player test. Big cheers for the hard wrok! (dont't wrok the grass por favore..)

[Pete Mack]

OK, I got a bit further by removing:
player/.*.h
object/.*.h
monster/.*.h
from Makefile.inc

However, I am still seeing:

C:\Projects\Exp\npp-0.5.1-src-WIP\src>make -f Makefile.win
gcc -DWINDOWS -Wall -Wextra -Wno-unused-parameter -std=iso9899:199409 -pedantic
-O2 -I. -mno-cygwin -c -o dungeon.o dungeon.c
dungeon.c: In function `recharge_objects':
dungeon.c:524: warning: ISO C90 forbids mixed declarations and code
dungeon.c:540: error: initializer element is not constant
make: *** [dungeon.o] Error 1
C:\Projects\Exp\npp-0.5.1-src-WIP\src>make -f Makefile.win
gcc -DWINDOWS -Wall -Wextra -Wno-unused-parameter -std=iso9899:199409 -pedantic
-O2 -I. -mno-cygwin -c -o dungeon.o dungeon.c
dungeon.c: In function `recharge_objects':
dungeon.c:541: error: initializer element is not constant
make: *** [dungeon.o] Error 1
gcc -DWINDOWS -Wall -Wextra -Wno-unused-parameter -std=iso9899:199409 -pedantic
-O2 -I. -mno-cygwin -c -o feature.o feature.c
feature.c: In function `get_feat_num':
feature.c:1559: error: syntax error before '/' token
make: [feature.o] Error 1 (ignored)
gcc -DWINDOWS -Wall -Wextra -Wno-unused-parameter -std=iso9899:199409 -pedantic
-O2 -I. -mno-cygwin -c -o melee1.o melee1.c
melee1.c: In function `make_attack_ranged':
melee1.c:3986: error: `true' undeclared (first use in this function)
melee1.c:3986: error: (Each undeclared identifier is reported only once
melee1.c:3986: error: for each function it appears in.)
make: [melee1.o] Error 1 (ignored)

I recommend trying to build with:

CFLAGS += $(WARNINGS) -std=iso9899:199409 -pedantic -O2 -I.
or update all gcc-dependent makefiles to use the options of your choice.


There are also lots of warnings, some of them are scary.
Like:

cmd4.c: In function `do_cmd_change_name':
cmd4.c:215: warning: comparison is always false due to limited range of data typ
e
cmd4.c:226: warning: comparison is always false due to limited range of data typ
e
cmd4.c: In function `do_cmd_messages':
cmd4.c:387: warning: comparison is always false due to limited range of data typ
e
cmd4.c:397: warning: comparison is always false due to limited range of data typ
e
cmd4.c:407: warning: comparison is always false due to limited range of data typ
e
cmd4.c:414: warning: comparison is always false due to limited range of data typ
e
cmd4.c: In function `do_cmd_macro_aux':
cmd4.c:685: warning: comparison is always true due to limited range of data type

I find MinGW a lot more useful than lcc. It's a lot more standards-compliant (whichever standard you pick), and the warnings are much, much stronger.

Visual Studio can help too--the MSVC compiler catches different errors, although setting up a project file is a bit of a pain.

Edit:
PS: the version of cmd-know.c you are using is not copyright by me. (I had nothing to do with it. I want nothing to do with it...)

[nppangband]

Originally Posted by Pete Mack

I find MinGW a lot more useful than lcc. It's a lot more standards-compliant (whichever standard you pick), and the warnings are much, much stronger.

Thanks. I intended to download and workwith MinGW today, but I was killing bugs all day long today.

I think I know what most of those warnings are & the fixes are simple. I will get to work on them & get a clean compile with MinGW.

[ekolis]

Do you have a repository out there we can download the latest code from, or will we have to wait for the next WIP version?

[nppangband]

Originally Posted by ekolis

Do you have a repository out there we can download the latest code from, or will we have to wait for the next WIP version?

We have an old one that is out of date. I do intend on setting up a new one once things calm down. I will put out another WIP in a day or two. I am happy to send the altered source files or a diff file to anyone who wants one.

[nppangband]

Originally Posted by Pete Mack

I recommend trying to build with:

CFLAGS += $(WARNINGS) -std=iso9899:199409 -pedantic -O2 -I.
or update all gcc-dependent makefiles to use the options of your choice.

I did RTFM before I ask these stupid questions, I promise.

I downloaded WINGW (into C:\WinGW) using the automated installer with "MINGW Make" added, added C:\WinGW\bin; to the Environment Variable, rebooted, went to the windows command prompt, got to the source directory, and typed:

make -f makefile.win. MINGW=yes (Is this right command prompt?)

I get the error: 'make" is not recognized as an internal or external command, operable program, or batch file.

I looked, and the wingw\bin directory doesn't have a file or application called "make". It has a mingw32-make. What command should I use?

Also, @Pete: Are you saying this line should be added to the command line or the makefile?

CFLAGS += $(WARNINGS) -std=iso9899:199409 -pedantic -O2 -I.

Thanks for any suggestions anyone may have.

[ekolis]

Have you tried msys? That might be the command-line you're after...

[andrewdoull]

Originally Posted by nppangband

I did RTFM before I ask these stupid questions, I promise.

I downloaded WINGW (into C:\WinGW) using the automated installer with "MINGW Make" added, added C:\WinGW\bin; to the Environment Variable, rebooted, went to the windows command prompt, got to the source directory, and typed:

make -f makefile.win. MINGW=yes (Is this right command prompt?)

I get the error: 'make" is not recognized as an internal or external command, operable program, or batch file.

I looked, and the wingw\bin directory doesn't have a file or application called "make". It has a mingw32-make. What command should I use?

Use mingw32-make. IIRC Mingw32 prefixes any command where the semantics are not identical to the Unix equivalent.

Andrew

[nppangband]

Yep. I tried that, and it didn't work.

But I did get cygwin (with gcc) set up and working. So I am going through all of those compile errors now. And you are right, Pete. There are *alot* of them.

Strangely, LCC-WIN had a complete meltdown and won't compile anything any more. It keeps saying it can't compile any straight c commands like ferror or fputc. I believe something in the latest windows update or my latest firewall update has blocked LCCWin's access to the standard C library.