Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old November 15, 2010, 09:37   #1
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,605
PowerWyrm is on a distinguished road
Bug with ego armor

Since changeset 1757 (closing ticket #782), M lines have been added to ego_item.txt to fix minimum values for to-hit, to-dam, to-ac and pval.
Correct me if I'm wrong, but all ego armor now have lost their penalty to-hit:
Chain Mail of Resistance (-2) [14,+10] has become Chain Mail of Resistance [14,+10] due to the code added in apply_magic()

Code:
/* Apply minimums */
if (o_ptr->to_h < e_ptr->min_to_h) o_ptr->to_h = e_ptr->min_to_h;
No minimum set for the ego, defaulted to zero...
Maybe change that to:

Code:
/* Apply minimums */
if (e_ptr->min_to_h && o_ptr->to_h < e_ptr->min_to_h) o_ptr->to_h = e_ptr->min_to_h;
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old November 15, 2010, 13:57   #2
d_m
Angband Devteam member
 
d_m's Avatar
 
Join Date: Aug 2008
Location: Philadelphia, PA, USA
Age: 38
Posts: 1,516
d_m is on a distinguished road
Thanks, I don't have time to test this, but it looks like you're right. I will fix it soon if no one else gets to it.
__________________
linux->xterm->screen->pmacs
d_m is offline   Reply With Quote
Old November 15, 2010, 16:13   #3
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,795
Derakon is on a distinguished road
Of course, that means that you can no longer set a minimum of 0, but it's better than the current behavior.
Derakon is offline   Reply With Quote
Old November 15, 2010, 18:38   #4
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by Derakon View Post
Of course, that means that you can no longer set a minimum of 0, but it's better than the current behavior.
I think I'd like to argue for ego armour not having to-hit penalties. Yes this current behaviour is unintentional, but I think I quite like it. Anyone?
Magnate is offline   Reply With Quote
Old November 15, 2010, 18:42   #5
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
I think the penalties should be dex penalties instead of [or in addition to] hit penalties, and egos shouldn't help. Maybe twice the value currently used. Heavy armor ought to be encumbering.
PowerDiver is offline   Reply With Quote
Old November 15, 2010, 18:44   #6
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Quote:
Originally Posted by PowerDiver View Post
I think the penalties should be dex penalties instead of [or in addition to] hit penalties, and egos shouldn't help. Maybe twice the value currently used. Heavy armor ought to be encumbering.
That's reflected in it using up your weight allowance, surely?
Magnate is offline   Reply With Quote
Old November 15, 2010, 20:20   #7
Derakon
Prophet
 
Derakon's Avatar
 
Join Date: Dec 2009
Posts: 8,795
Derakon is on a distinguished road
If I strap heavy plate armor onto you, you aren't going to be able to swing your arms as quickly. Currently you still get max blows even if you're 600 pounds over your weight limit, so long as you meet the STR/DEX breakpoints.

That said, this would obviously have to wait for multiple pvals and fractional blows (lest the impact of -1 dex from your armor halve your offensive capabilities), and even then I'm not convinced it's a good idea.
Derakon is offline   Reply With Quote
Old November 16, 2010, 12:22   #8
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,605
PowerWyrm is on a distinguished road
Quote:
Originally Posted by Magnate View Post
I think I'd like to argue for ego armour not having to-hit penalties. Yes this current behaviour is unintentional, but I think I quite like it. Anyone?
But the artifacts still get the to-hit penalty (and some even get a higher penalty)... so why not the egos?
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old November 16, 2010, 15:39   #9
Timo Pietilš
Prophet
 
Join Date: Apr 2007
Location: Climbing up from hole I just dug.
Posts: 4,096
Timo Pietilš is on a distinguished road
Quote:
Originally Posted by PowerWyrm View Post
But the artifacts still get the to-hit penalty (and some even get a higher penalty)... so why not the egos?
IIRC they have it set in artifact.txt, otherwise they don't have that penalty. Look at Isildur, it doesn't have the penalty.
Timo Pietilš is offline   Reply With Quote
Old November 16, 2010, 17:44   #10
PowerDiver
Prophet
 
Join Date: Mar 2008
Posts: 2,712
PowerDiver is on a distinguished road
Quote:
Originally Posted by Derakon View Post
That said, this would obviously have to wait for multiple pvals and fractional blows (lest the impact of -1 dex from your armor halve your offensive capabilities), and even then I'm not convinced it's a good idea.
Heavy armor is a tradeoff of defense vs offense. I see no reason it should not cut your offense in half. I wouldn't mind energy per blow being increased by a factor something like weight/50lb. Of course, this is yet another example screwing warriors and leaving mages as the ones using heavy armor. So long as monsters do more damage with breaths than with melee I don't see this changing.
PowerDiver is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
r1676 - Random Ability Bug on Ego Sirridan Development 11 September 25, 2009 00:35
Test-Id for armor Donald Jonker Vanilla 3 May 20, 2009 10:00
3.1 bug: ego armor squelch quality ChodTheWacko Vanilla 1 April 11, 2009 19:19
Rogue Armor - How Heavy Should I Go? SocietalEclipse Vanilla 2 March 14, 2009 22:25
Need some Weapon and Armor advice. marteo Vanilla 14 February 10, 2009 13:25


All times are GMT +1. The time now is 22:22.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.