Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old August 25, 2011, 08:30   #1
PowerWyrm
Prophet
 
PowerWyrm's Avatar
 
Join Date: Apr 2008
Posts: 2,565
PowerWyrm is on a distinguished road
[3.3] Little miscalculation in randart frequency count for slays

See randart.c

In 3.2, the code was doing this:

Code:
flags_init(mask, OF_SIZE, OF_BRAND_MASK, FLAG_END);
temp2 = list_slays(a_ptr->flags, mask, NULL, NULL, NULL, FALSE); 
flags_init(mask, OF_SIZE, OF_ALL_SLAY_MASK, FLAG_END); 
temp = list_slays(a_ptr->flags, mask, NULL, NULL, NULL, FALSE) - temp2;

file_putf(log_file, "Adding %d for slays\n", temp);
file_putf(log_file, "Adding %d for brands\n", temp2);

artprobs[XXX_SLAY] += temp;
artprobs[XXX_BRAND] += temp2;
In 3.3, the code was changed to:

Code:
create_mask(mask, FALSE, OFT_SLAY, OFT_BRAND, OFT_KILL, OFT_MAX);
temp = list_slays(flags, mask, NULL, NULL, NULL, FALSE);
create_mask(mask, FALSE, OFT_BRAND, OFT_MAX);
temp2 = list_slays(flags, mask, NULL, NULL, NULL, FALSE);

file_putf(log_file, "Adding %d for slays\n", temp - temp2);
file_putf(log_file, "Adding %d for brands\n", temp2);
*** artprobs[XXX_SLAY] += temp; ***
artprobs[XXX_BRAND] += temp2;
I think the line with ***s should be changed to:

artprobs[XXX_SLAY] += (temp - temp2);
__________________
PWMAngband variant maintainer - check http://powerwyrm.monsite-orange.fr (or http://www.mangband.org/forum/viewforum.php?f=9) to learn more about this new variant!
PowerWyrm is offline   Reply With Quote
Old August 25, 2011, 10:35   #2
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,057
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate
Good catch, thank you. This will be fixed in 3.3.1
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
changing sensing to imply knowing flag count PowerDiver Development 3 June 21, 2011 00:34
Kill count, hall of fame Raggy Vanilla 10 June 6, 2011 22:07
RandArts: total artifact count? Chud Vanilla 10 November 27, 2010 20:41
Branded weapons and slays Donald Jonker Vanilla 2 October 22, 2008 22:54
Real nooby question about slays Jude Vanilla 5 December 14, 2007 15:29


All times are GMT +1. The time now is 11:15.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.