Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old September 19, 2011, 00:09   #1
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,008
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Untraceable bug in dev versions - help!

I think I've found a bug which is in the most recent dev version and also in the 3.3-release branch, but is not in 3.3.0. The ticket is http://trac.rephial.org/ticket/1536. Every time I use a wand, staff or rod it is instantly IDd.

If you are playing the most recent dev version and do not see this behaviour, please post a savefile.

If you notice it start or stop happening, please describe.

If you happen to have any ideas about what's caused it, please let me know. If you're using git and you type

git log -p 3.3-release ^v3.3.0

you can see every single line of code which has been changed since 3.3.0 was released - there aren't many and I can't see anything in there which is remotely related, but maybe someone else can.

(You do need an up-to-date local 3.3-release branch to do this: git fetch official ; git checkout official/3.3-release ; git checkout -b 3.3-release)

EDIT: I'm asking for help because this is the last serious bug holding up the release of 3.3.1 ...
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old September 19, 2011, 11:32   #2
Nomad
Swordsman
 
Nomad's Avatar
 
Join Date: Sep 2010
Location: England
Posts: 458
Nomad is on a distinguished road
I downloaded the latest nightly, and yes, I get this behaviour. If it helps, I can confirm that it was introduced since the September 5th (g005ced9) nightly - that's the version I've been playing, and it doesn't have this bug.

Last edited by Nomad; September 19, 2011 at 11:46.
Nomad is offline   Reply With Quote
Old September 19, 2011, 13:26   #3
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,008
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by Nomad View Post
I downloaded the latest nightly, and yes, I get this behaviour. If it helps, I can confirm that it was introduced since the September 5th (g005ced9) nightly - that's the version I've been playing, and it doesn't have this bug.
That does help - thank you. I've still no idea how it was introduced, but at least you've narrowed it down.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old September 19, 2011, 16:36   #4
fizzix
Prophet
 
Join Date: Aug 2009
Location: Madison, Wisconsin, US
Posts: 2,648
fizzix is on a distinguished road
bug seems to be introduced in 87b2b3c3d, the fix for #1533

edit: aiming a wand seems to call project_p which includes the new line.
Code:
if (who == -1) return obvious;
who == -1 means that it's the player, so it's returning obvious every time the player fires a wand.

This fix was in respect to a crash bug in Openbsd, so it's hard to judge what needs to be done without reintroducing the original bug.

Last edited by fizzix; September 19, 2011 at 17:07.
fizzix is offline   Reply With Quote
Old September 19, 2011, 17:13   #5
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 5,008
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by fizzix View Post
bug seems to be introduced in 87b2b3c3d, the fix for #1533

edit: aiming a wand seems to call project_p which includes the new line.
Code:
if (who == -1) return obvious;
who == -1 means that it's the player, so it's returning obvious every time the player fires a wand.

This fix was in respect to a crash bug in Openbsd, so it's hard to judge what needs to be done without reintroducing the original bug.
Thank you. I was looking in project_m, forgetting that project() calls project_p even when it doesn't need to.

This shouldn't be too hard to fix now you've identified the problem. I'll try and sort it out tonight. I am confident of not reintroducing the original bug (which was an invalid call to cave_monster).

EDIT: fixed in f6b7d3f
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

Last edited by Magnate; September 19, 2011 at 17:58.
Magnate is offline   Reply With Quote
Old September 20, 2011, 22:04   #6
AnonymousHero
Knight
 
AnonymousHero's Avatar
 
Join Date: Jun 2007
Posts: 608
AnonymousHero is on a distinguished road
I realize that this has already been fixed, but...

Magnate, you should really try "git bisect". It usually makes tracking down this kind of thing pretty easy.
AnonymousHero is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
A question to the dev team regarding new ID-by-use (possible bug) PowerWyrm Vanilla 3 August 27, 2010 18:30
Using nightly/dev versions Magnate Vanilla 2 September 1, 2009 20:33
Dev Bug rdermyer Vanilla 13 December 24, 2008 03:49
Fear Bug In Dev Version LordArcher Vanilla 2 November 30, 2008 21:04
[Dev] major Fear bug. Irashtar Vanilla 1 August 31, 2008 04:03


All times are GMT +1. The time now is 19:31.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.