Wand of slow monster bug?

BlueFish · September 25, 2011, 23:26

I just shot a scruffy hobbit with a wand of slow monster 3 times, got the message that he "looked slowed", then "more slowed", then "more slowed". He still kept up with me step for step after that. This is in 3.3.1.

Magnate · September 26, 2011, 16:50

This is very interesting. I can't find the code that actually slows the monster down! Working on it ...

Magnate · September 26, 2011, 17:06

Bother. Somehow the code stanza in dungeon.c which makes this happen got elided. Thanks for the bug report - looks like we will need a 3.3.2 after all ...

fizzix · September 26, 2011, 17:42

there was an issue of the slowing down stacking. Was the elision a result of fixing this bug?

Derakon · September 26, 2011, 18:10

I'm pretty sure we had a (possibly not released) version in between "Slow Monster is overpowered" and "Slow Monster doesn't work". If only because I have faith in our devs to test their work.

Magnate · September 26, 2011, 18:41

Quote:

Originally Posted by Derakon

I'm pretty sure we had a (possibly not released) version in between "Slow Monster is overpowered" and "Slow Monster doesn't work". If only because I have faith in our devs to test their work.

Well, in order to fix the "wands IDd on unseen monsters don't give any messages" problem I had to backport a fairly large mon-timed refactor back to the 3.3-release branch. This was in one of the two RC releases of 3.3.1 in the days prior to its release. Looks like I didn't do or allow enough time for testing, because this didn't get picked up then. I of course had concentrated on the messaging (which is fine!) and failed to notice that the slow effect wasn't actually happening.

Before I release 3.3.2 I need to check that none of other timed status effects are broken ...

Derakon · September 26, 2011, 19:35

Er, yes. I meant that when you fixed the "Slow Monster is overpowered" you presumably tested that it was no longer, in fact, overpowered. You didn't test for unexpected changes elsewhere, which is usually how bugs sneak their way in.

A unit test suite for Angband would be pretty heinous...

Magnate · September 26, 2011, 23:53

Quote:

Originally Posted by Derakon

Er, yes. I meant that when you fixed the "Slow Monster is overpowered" you presumably tested that it was no longer, in fact, overpowered. You didn't test for unexpected changes elsewhere, which is usually how bugs sneak their way in.

A unit test suite for Angband would be pretty heinous...

Heh - we do actually have over a hundred unit tests now ... and code coverage is 10.4%. So just under nine hundred more tests to write then ...

September 25, 2011, 23:26	#1
BlueFish Apprentice Join Date: Aug 2011 Posts: 80	Wand of slow monster bug? I just shot a scruffy hobbit with a wand of slow monster 3 times, got the message that he "looked slowed", then "more slowed", then "more slowed". He still kept up with me step for step after that. This is in 3.3.1.

September 26, 2011, 16:50	#2
Magnate Angband Devteam member Join Date: May 2007 Location: London, UK Posts: 4,802	This is very interesting. I can't find the code that actually slows the monster down! Working on it ... __________________ "3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

September 26, 2011, 17:06	#3
Magnate Angband Devteam member Join Date: May 2007 Location: London, UK Posts: 4,802	Bother. Somehow the code stanza in dungeon.c which makes this happen got elided. Thanks for the bug report - looks like we will need a 3.3.2 after all ... __________________ "3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Player is a monster. Bug?	flammableBen	Vanilla	17	July 30, 2011 04:10
Wands of Slow Monster are awesome	Derakon	Development	19	July 22, 2011 01:24
Wand of Wonder spoilers	Derakon	Vanilla	6	November 2, 2010 00:45
Bug with monster light?	miyazaki	Vanilla	1	July 22, 2010 09:00
Rod/wand/staff failure rates?	Geofferic	Vanilla	2	October 22, 2007 06:38

September 26, 2011, 17:42	#4
fizzix Veteran Join Date: Aug 2009 Location: Madison, Wisconsin, US Posts: 2,298	there was an issue of the slowing down stacking. Was the elision a result of fixing this bug?

September 26, 2011, 18:10	#5
Derakon Prophet Join Date: Dec 2009 Posts: 4,752	I'm pretty sure we had a (possibly not released) version in between "Slow Monster is overpowered" and "Slow Monster doesn't work". If only because I have faith in our devs to test their work.

September 26, 2011, 19:35	#7
Derakon Prophet Join Date: Dec 2009 Posts: 4,752	Er, yes. I meant that when you fixed the "Slow Monster is overpowered" you presumably tested that it was no longer, in fact, overpowered. You didn't test for unexpected changes elsewhere, which is usually how bugs sneak their way in. A unit test suite for Angband would be pretty heinous...

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)