Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old February 29, 2012, 18:47   #1
Old Coach
Apprentice
 
Join Date: Feb 2009
Posts: 61
Old Coach is on a distinguished road
npp floor interaction bug

Is anyone else having trouble interacting with items on the floor? When my inventory is mostly empty, I rarely have problems. However, once I start getting above around 12 items in my inventory, I start having the following problem:

When I try to Identify an item on the floor, the game crashes.
When I try to pick up an item with the g command, the game crashes. I can avoid this problem if I pick up items automatically or with the 5 command, and then identify them from my inventory. This crash happens irregardless of what graphics I am using, and also whether or not I am enabling the drop down menus (interface options).

It could just be an artifact of my old computer.

Also, giant white rats come up brown with the new tile set
Old Coach is offline   Reply With Quote
Old February 29, 2012, 19:11   #2
ghengiz
Adept
 
ghengiz's Avatar
 
Join Date: Nov 2011
Location: Roaming in Terry Pratchett's Discworld
Posts: 178
ghengiz is on a distinguished road
Quote:
Originally Posted by Old Coach View Post
Is anyone else having trouble interacting with items on the floor? When my inventory is mostly empty, I rarely have problems. However, once I start getting above around 12 items in my inventory, I start having the following problem:

When I try to Identify an item on the floor, the game crashes.
When I try to pick up an item with the g command, the game crashes. I can avoid this problem if I pick up items automatically or with the 5 command, and then identify them from my inventory. This crash happens irregardless of what graphics I am using, and also whether or not I am enabling the drop down menus (interface options).

It could just be an artifact of my old computer.

Also, giant white rats come up brown with the new tile set
I'm not sure if this qualify as a crash, but something along this lines just happened to me too. Details follow.

port:gcu
options: autopickup off, prompt beforeusing floor items = yes, prompt before picking things up = yes.
inventory slots a-l not empty; the moment I picked up the 'm'-slot object (iron spikes), the screen bocome black, only the @ and the cursor are visible, but the game is not hung, because it responds to the movement, inventory, equipment, options, run commands and probably others.
refreshing the screen doesn't help

I cannot confirm the identify issue because I have no id scrolls at the moment.

edit:
saving and reloading fixes the display
ghengiz is offline   Reply With Quote
Old February 29, 2012, 20:00   #3
nppangband
NPPAngband Maintainer
 
Join Date: Dec 2008
Location: Stat Gain, Angband
Posts: 819
nppangband is on a distinguished road
Thanks, I will try to re-create this. Just curious what version you downloaded, and at what time it was downloaded. I have been uploading fixes to github, and I uploaded one this morning regarding item selection that, now that I think about it, could possibly result in crashes in the situation you describe below (picking up items off the floor, identifying items). If by chance you come across this bug shortly after saving an item, please send me the savefile.

@old coach - I think I know what is happening in your situation. I should be able to put out a fix when I get home from work.

The reason the game is crashing is because in certain circumstances the game returns the slot of an item on the floor as negative, and it has to be changed to a positive before accessing the object information in the object table. I recently tied the floor pickup menu to the new ui menu, and I think I know where the signs might be mixed up in the code that handles object pickup.
__________________
NPPAngband current home page: http://forum.nppangband.org/
Source code repository:
https://github.com/nppangband/NPPAngband
nppangband is offline   Reply With Quote
Old March 1, 2012, 01:22   #4
buzzkill
Prophet
 
buzzkill's Avatar
 
Join Date: May 2008
Location: Indiana, USA
Posts: 2,916
Donated: $8
buzzkill is on a distinguished road
Quote:
Originally Posted by Old Coach View Post
Also, giant white rats come up brown with the new tile set
Fixed on my end. Thanks.
__________________
www.mediafire.com/buzzkill - Get your 32x32 tiles here. UT32 now compatible Ironband and Quickband 9/6/2012.
My banding life on Buzzkill's ladder.
buzzkill is offline   Reply With Quote
Old March 1, 2012, 01:59   #5
nppangband
NPPAngband Maintainer
 
Join Date: Dec 2008
Location: Stat Gain, Angband
Posts: 819
nppangband is on a distinguished road
Quote:
Originally Posted by ghengiz View Post
I'm not sure if this qualify as a crash, but something along this lines just happened to me too. Details follow.

port:gcu
options: autopickup off, prompt beforeusing floor items = yes, prompt before picking things up = yes.
inventory slots a-l not empty; the moment I picked up the 'm'-slot object (iron spikes), the screen bocome black, only the @ and the cursor are visible, but the game is not hung, because it responds to the movement, inventory, equipment, options, run commands and probably others.
refreshing the screen doesn't help

I cannot confirm the identify issue because I have no id scrolls at the moment.

edit:
saving and reloading fixes the display
This one should be fixed too. Inthe pickup menu There was a leftover screen_load without a corresponding screen save, so it loaded a blank screen.
__________________
NPPAngband current home page: http://forum.nppangband.org/
Source code repository:
https://github.com/nppangband/NPPAngband
nppangband is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Green floor tiles Raggy Vanilla 12 June 20, 2011 16:02
NPP crash bug under Visual C++ debug compile Antoine Development 13 February 19, 2011 23:18
trappers vs floor ChodTheWacko Vanilla 8 December 20, 2010 18:14
3.1.0 beta - minor bug? - green lit floor tiles in prelit rooms vorondil Vanilla 2 January 8, 2009 19:12
NPP 0.5.0 Beta 4 Bug???? Rizwan Variants 2 February 6, 2008 13:44


All times are GMT +1. The time now is 07:11.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.