Angband.oook.cz
Angband.oook.cz
AboutDownloadVariantsLadderForumCompetitionSpoilersComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Development

Reply
 
Thread Tools Display Modes
Old March 27, 2012, 15:04   #1
Gorbad
Apprentice
 
Join Date: Sep 2008
Posts: 59
Gorbad is on a distinguished road
[3.3.2] Assertion failed in mon-time.c

In the current competion (119) I encountered an assertion in

monster/mon-timed.c line 247: timer > 0

I couldn't find a similar issue on rephial, but I seem to remember reading it before on oook.

I have/will keep a savefile if needed.
Gorbad is offline   Reply With Quote
Old March 27, 2012, 15:18   #2
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
Quote:
Originally Posted by Gorbad View Post
In the current competion (119) I encountered an assertion in

monster/mon-timed.c line 247: timer > 0

I couldn't find a similar issue on rephial, but I seem to remember reading it before on oook.

I have/will keep a savefile if needed.
Thanks -- this was just fixed recently in 3.4-dev.

Magnate: maybe we should port this change to 3.3.2 and update it for the competition?

In the meanwhile, avoid impact hounds >_>
CunningGabe is offline   Reply With Quote
Old March 27, 2012, 16:09   #3
Gorbad
Apprentice
 
Join Date: Sep 2008
Posts: 59
Gorbad is on a distinguished road
Quote:
Originally Posted by CunningGabe View Post
In the meanwhile, avoid impact hounds >_>
Good advice at all times
Gorbad is offline   Reply With Quote
Old March 27, 2012, 18:30   #4
Magnate
Angband Devteam member
 
Join Date: May 2007
Location: London, UK
Posts: 4,994
Magnate is on a distinguished road
Send a message via MSN to Magnate Send a message via Yahoo to Magnate Send a message via Skype™ to Magnate
Quote:
Originally Posted by CunningGabe View Post
Magnate: maybe we should port this change to 3.3.2 and update it for the competition?
Hmmm. I hadn't realised there was another 3.3.2 comp running. I hope that we'll be fixing a 3.4 release date on Saturday, so I'd rather not release a 3.3.3 as well. But if it's going to be a long time then that's a different story. Let's revisit the issue at the weekend.

Meanwhile, was it only the one line that needed fixing? ISTR from PowerWyrm that there were other values in project_m that might end up at 0 by the same sort of accident, but I'm not certain.
__________________
"3.4 is much better than 3.1, 3.2 or 3.3. It still is easier than 3.0.9, but it is more convenient to play without being ridiculously easy, so it is my new favorite of the versions." - Timo Pietila
Magnate is offline   Reply With Quote
Old March 27, 2012, 18:37   #5
CunningGabe
Swordsman
 
Join Date: Feb 2008
Location: Boston, MA
Posts: 250
CunningGabe is on a distinguished road
Quote:
Originally Posted by Magnate View Post
Hmmm. I hadn't realised there was another 3.3.2 comp running. I hope that we'll be fixing a 3.4 release date on Saturday, so I'd rather not release a 3.3.3 as well. But if it's going to be a long time then that's a different story. Let's revisit the issue at the weekend.

Meanwhile, was it only the one line that needed fixing? ISTR from PowerWyrm that there were other values in project_m that might end up at 0 by the same sort of accident, but I'm not certain.
I think everything else should be okay other than that one line. In each case, before we call mon_inc_timed, we already check whether the timer increment is nonzero. The only problem with stunning is that we potentially modified that number in between checking and sending the call to mon_inc_timed.
CunningGabe is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Bug in Monster/Mon-timed.c mixer Vanilla 2 December 17, 2011 10:25
Assertion failed in object\identify.c jens Development 10 June 14, 2011 14:48
game crash on failed lock pick (version 2034) fizzix Development 7 August 7, 2010 20:08
Long time player, first time poster Deranged Archivist Vanilla 6 October 14, 2009 15:19
Failed to Create Temporary File \s87g.1. d1sc0nnected Vanilla 2 April 2, 2008 18:45


All times are GMT +1. The time now is 16:21.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.