Fixing dir, shift-dir and ctrl-dir keys part 1: Win client

[fizzix]

Originally Posted by PowerWyrm

I know TomeNET disables numlock by default, maybe V should do the same...

I'm thinking this is the way to go also.

[PowerWyrm]

Originally Posted by PowerWyrm

Ah ok... that explains the behavior of keypresses on SDL and GCU clients, so the same behavior should indeed be applied with Windows. NUMLOCK off should be the default and shift-keypad with numlock off should work as expected.

So the correct behavior should be:
- press keypad with numlock off: virtual key (left, right, down, up, home, end, pgup, pgdn)
- press keypad with numlock on: numeric key (1, 2, 3, 4, 6, 7, 8, 9)
- press shift+keypad with numlock off: shift+virtual key (shift+left, shift+right, shift+down, shift+up, shift+home, shift+end, shift+pgup, shift+pgdn)
- press shift+keypad with numlock on: virtual key (left, right, down, up, home, end, pgup, pgdn)

The game should then ensure than numlock is off and that the virtual keys are mapped to the numeric keys in pref.prf (which should be the case).

[PowerWyrm]

This also implies fixing pref.prf to map the virtual key VK_DELETE to the numeric '.' so that running is possible with numlock off by pressing the game command.

[PowerWyrm]

Hmm what's the expected behavior of control+numpad? Currently, pressing control+numpad does nothing when numlock is on, since the VK_NUMPAD keys are not handled in handle_keydown().

Note that handling VK_NUMPAD keys in handle_keydown() leads to the old bug of double keypresses and should be avoided...

[half]

PowerWyrm,

I just wanted to say thanks for working on this. When you've stabilised on something, I definitely want to incorporate it into Sil. I just don't know enough about Windows to do it myself. I was actually pretty shocked that these things don't work properly on Windows (or Unix) and that it was been decades without it being fixed.