automatic lists+look & colored detection

[ChodTheWacko]

I downloaded the newest build, have a couple of comments for the masses:

1) I like the 'automatically show lists' option.
But I think it's awkward that it shows the lists for 'look' if I didn't do 'look'.
I was killing an orc pit and they were dropping things everywhere.
Walking through the room became annoying because it kept popping up the
'you see: ' list box for every step.


2) The 'show a colored dot where detect traps ends' is busted along the edges
of the map. Aka X=0 or Y=0 in absolute map coordinates.

If a room is placed aligned to the edge of the map, then colored dots
show up, along the edge, and they never go away.

Thanks for all the hard work.

[Big Al]

Re: trap detection edge: When I first made that patch, detection areas were still round; I tried it both ways (with and without the line along the map) and decided that it looked better with it. (Otherwise, you get these big circles that are cut off on the edges.) EDIT: Also, I had originally made it so that you could see the whole trap detection border - not just at the locations you have explored. I liked it better my way.

Actually, I don't think that it's necessary to have the green dotted line anymore. I've been playing around with it yesterday and I don't like it anymore. When detection areas were circular, it was really nice, but now it's just a pain.

I'd propose removing the green line and replacing it with a message along the lines of "You can't run into undetected territory." or something. I think that we need a message of some kind, instead of just mysteriously not being able to run occasionally.

[takkaria]

Originally Posted by ChodTheWacko

1) I like the 'automatically show lists' option.
But I think it's awkward that it shows the lists for 'look' if I didn't do 'look'.
I was killing an orc pit and they were dropping things everywhere.
Walking through the room became annoying because it kept popping up the
'you see: ' list box for every step.

Try turning off pickup_detail -- that should make it stop.

[CunningGabe]

Originally Posted by Big Al

Actually, I don't think that it's necessary to have the green dotted line anymore. I've been playing around with it yesterday and I don't like it anymore. When detection areas were circular, it was really nice, but now it's just a pain.

I'm the one who applied your patch to existing code, and I'm happy to remove it and try to get a message to work, but I'm curious: why does it matter less now that detection areas are rectangular instead of circular?

[CunningGabe]

Originally Posted by ChodTheWacko

2) The 'show a colored dot where detect traps ends' is busted along the edges
of the map. Aka X=0 or Y=0 in absolute map coordinates.

If a room is placed aligned to the edge of the map, then colored dots
show up, along the edge, and they never go away.

This is fixed now. Also, the DTrap indicator now turns yellow when you're standing on the DTrap border.

[Big Al]

Originally Posted by CunningGabe

I'm the one who applied your patch to existing code, and I'm happy to remove it and try to get a message to work, but I'm curious: why does it matter less now that detection areas are rectangular instead of circular?

Because if it's rectangular, then I know to redetect every time that the map panel moves. If it's circular, then I don't know where the edges of the circle are - circles overlap and it gets messy. I guess I'm getting used to it now - especially with the yellow dTrap indicator which helps a lot. I'm playing on a crappy monitor and it's kind of hard to distinguish between the light green and white, but this helps.

(Thanks for putting the patch in, btw.)