Angband.oook.cz
Angband.oook.cz
AboutVariantsLadderForumCompetitionComicScreenshotsFunniesLinks

Go Back   Angband Forums > Angband > Vanilla

Reply
 
Thread Tools Display Modes
Old April 28, 2016, 10:48   #1
calris
Adept
 
Join Date: Mar 2016
Posts: 194
calris is on a distinguished road
Connected stairs option does not save

Playing the latest Traps branch (i.e. with Rune ID) I notice the 'Generate Connected Stairs' option keeps resetting to 'Yes' after saving
calris is offline   Reply With Quote
Old July 6, 2016, 22:29   #2
t4nk
Adept
 
Join Date: May 2016
Posts: 249
t4nk is on a distinguished road
Yeah, I'm playing master and I noticed that too. That's because the string "birth_connect_stairs" is 20 bytes long (not counting the terminating null byte). But the options loader (rd_options() in load.c) has only 20 byte buffer (lines 396-406):
Code:
    while (1) {
        byte value;
        char name[20];
        rd_string(name, sizeof name);

        if (!name[0])
            break;

        rd_byte(&value);
        option_set(name, !!value);
    }
and rd_string() does (line 302 of savefile.c):
Code:
void rd_string(char *str, int max)
{
    ...
    str[max - 1] = '\0';
}
so name turns out to be "birth_connect_stair" (without "s" at the end).
I didn't find a ticket on trac.rephial.org; perhaps thats already fixed?
t4nk is offline   Reply With Quote
Old October 26, 2016, 11:17   #3
Nick
Vanilla maintainer
 
Nick's Avatar
 
Join Date: Apr 2007
Location: Canberra, Australia
Age: 52
Posts: 6,578
Donated: $60
Nick is on a distinguished road
Quote:
Originally Posted by t4nk View Post
I didn't find a ticket on trac.rephial.org; perhaps thats already fixed?
You vastly overestimate how organised our ticketing is. Now fixed in development.
__________________
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them.
Nick is offline   Reply With Quote
Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Can't save/won't save keymaps Feloniousmonk Vanilla 3 April 4, 2013 14:54
*Destruction* deletes stairs bron Vanilla 7 August 27, 2011 04:44
Connected stairs - something to consider Antoine Development 17 May 14, 2011 08:51
Playing with 'restricted' stairs fizzix AAR 0 July 20, 2010 00:12
can't load save file. anti-save scumming feature? unbuttered_toast Vanilla 4 May 21, 2010 17:57


All times are GMT +1. The time now is 03:28.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.